[BitcodeReader] Add bounds checking on Strtab #76403
Conversation
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write If you have received no comments on your PR for a week, you can request a review If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
This is needed to protect against global overflows, which was found by a fuzzer recently. Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65283 Signed-off-by: David Korczynski <david@adalogics.com>
| // Check Strtab has enough values for the partition. | ||
| if (Record[OpNum] + Record[OpNum + 1] > Strtab.size()) { | ||
| return error("Malformed partition, too large."); | ||
| } |
There was a problem hiding this comment.
| // Check Strtab has enough values for the partition. | |
| if (Record[OpNum] + Record[OpNum + 1] > Strtab.size()) { | |
| return error("Malformed partition, too large."); | |
| } | |
| // Check Strtab has enough values for the partition. | |
| if (Record[OpNum] + Record[OpNum + 1] > Strtab.size()) | |
| return error("Malformed partition, too large"); |
Signed-off-by: David Korczynski <david@adalogics.com>
This is needed to protect against global overflows, which was found by a fuzzer recently.
Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65283