-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unsigned typos #76670
Merged
Merged
Fix unsigned typos #76670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
Clang issues not falling into any other category
backend:AArch64
backend:WebAssembly
mc
Machine (object) code
mlir:linalg
mlir:python
MLIR Python bindings
mlir
labels
Jan 1, 2024
@llvm/pr-subscribers-backend-aarch64 @llvm/pr-subscribers-backend-webassembly Author: None (Rageking8) ChangesFull diff: https://github.com/llvm/llvm-project/pull/76670.diff 7 Files Affected:
diff --git a/clang/test/Analysis/additive-op-on-sym-int-expr.c b/clang/test/Analysis/additive-op-on-sym-int-expr.c
index bd951c4443a1be..a268baf0a5f18c 100644
--- a/clang/test/Analysis/additive-op-on-sym-int-expr.c
+++ b/clang/test/Analysis/additive-op-on-sym-int-expr.c
@@ -59,7 +59,7 @@ void testMin(int i, long l) {
clang_analyzer_dumpL(l - intMin); // expected-warning-re {{(reg_${{[0-9]+}}<long l>) + 2147483648 }} instead of - -2147483648
}
-void changingToUnsinged(unsigned u, int i) {
+void changingToUnsigned(unsigned u, int i) {
unsigned c = u + (unsigned)i;
unsigned d = u - (unsigned)i;
if (i == -1) {
@@ -89,7 +89,7 @@ void extendingToSigned(long l, int i) {
}
}
-void extendingToUnigned(unsigned long ul, int i) {
+void extendingToUnsigned(unsigned long ul, int i) {
unsigned long c = ul + (unsigned long)i;
unsigned long d = ul - (unsigned long)i;
if (i == -1) {
diff --git a/llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTypeUtilities.h b/llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTypeUtilities.h
index 18018dfc6d6fb9..486cf264d13e2f 100644
--- a/llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTypeUtilities.h
+++ b/llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTypeUtilities.h
@@ -46,7 +46,7 @@ inline bool isRefType(wasm::ValType Type) {
// Convert ValType or a list/signature of ValTypes to a string.
-// Convert an unsinged integer, which can be among wasm::ValType enum, to its
+// Convert an unsigned integer, which can be among wasm::ValType enum, to its
// type name string. If the input is not within wasm::ValType, returns
// "invalid_type".
const char *anyTypeToString(unsigned Type);
diff --git a/llvm/test/MC/AArch64/neon-diagnostics.s b/llvm/test/MC/AArch64/neon-diagnostics.s
index 481a5ddd6a83f9..9a0445131ddf7c 100644
--- a/llvm/test/MC/AArch64/neon-diagnostics.s
+++ b/llvm/test/MC/AArch64/neon-diagnostics.s
@@ -4877,7 +4877,7 @@
// CHECK-ERROR: ^
//----------------------------------------------------------------------
-// Scalar Unigned Rounding Shift Right (Immediate)
+// Scalar Unsigned Rounding Shift Right (Immediate)
//----------------------------------------------------------------------
urshr d20, d23, #99
diff --git a/llvm/test/MC/AArch64/neon-scalar-shift-imm.s b/llvm/test/MC/AArch64/neon-scalar-shift-imm.s
index 96cb815eafa816..db8e21a17a1d36 100644
--- a/llvm/test/MC/AArch64/neon-scalar-shift-imm.s
+++ b/llvm/test/MC/AArch64/neon-scalar-shift-imm.s
@@ -24,7 +24,7 @@
// CHECK: srshr d19, d18, #7 // encoding: [0x53,0x26,0x79,0x5f]
//----------------------------------------------------------------------
-// Scalar Unigned Rounding Shift Right (Immediate)
+// Scalar Unsigned Rounding Shift Right (Immediate)
//----------------------------------------------------------------------
urshr d20, d23, #31
diff --git a/llvm/test/MC/Disassembler/AArch64/neon-instructions.txt b/llvm/test/MC/Disassembler/AArch64/neon-instructions.txt
index ff7dedce444a4d..952ead99f92f76 100644
--- a/llvm/test/MC/Disassembler/AArch64/neon-instructions.txt
+++ b/llvm/test/MC/Disassembler/AArch64/neon-instructions.txt
@@ -1829,7 +1829,7 @@
0x53,0x26,0x79,0x5f
#----------------------------------------------------------------------
-# Scalar Unigned Rounding Shift Right (Immediate)
+# Scalar Unsigned Rounding Shift Right (Immediate)
#----------------------------------------------------------------------
# CHECK: urshr d20, d23, #31
0xf4,0x26,0x61,0x7f
diff --git a/mlir/docs/Dialects/Linalg/OpDSL.md b/mlir/docs/Dialects/Linalg/OpDSL.md
index 5c4c8b4e1880ae..9d324d8c538ac7 100644
--- a/mlir/docs/Dialects/Linalg/OpDSL.md
+++ b/mlir/docs/Dialects/Linalg/OpDSL.md
@@ -291,7 +291,7 @@ The following examples illustrate the lowering of signed and unsigned functions:
* cast_unsigned(I32 -> I64) -> `arith.ExtUIOp`
* cast_unsigned(F32 -> I32) -> `arith.FPToUIOp`
* max_signed -> `arith.MaxSIOp`
-* max_unsinged -> `arith.MaxUIOp`
+* max_unsigned -> `arith.MaxUIOp`
Not all functions are applicable for all numeric types, and on mismatch, op
verification will fail.
diff --git a/mlir/python/mlir/dialects/linalg/opdsl/lang/comprehension.py b/mlir/python/mlir/dialects/linalg/opdsl/lang/comprehension.py
index d9698e8ab867e4..23d6d26b7e294c 100644
--- a/mlir/python/mlir/dialects/linalg/opdsl/lang/comprehension.py
+++ b/mlir/python/mlir/dialects/linalg/opdsl/lang/comprehension.py
@@ -318,7 +318,7 @@ class BinaryFn:
Examples:
- max -> `arith.MaxSIOp`
- - max_unsinged -> `arith.MaxUIOp`
+ - max_unsigned -> `arith.MaxUIOp`
"""
add = BinaryFnType("add")
|
matthias-springer
approved these changes
Jan 1, 2024
Is this PR ready to merge? |
Yes, you can merge it. Thanks! Let me know if you don't have access |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend:AArch64
backend:WebAssembly
clang
Clang issues not falling into any other category
mc
Machine (object) code
mlir:linalg
mlir:python
MLIR Python bindings
mlir
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.