[lli] Revisit Orc debug output tests #76822
Conversation
weliveindetail
changed the title
weliveindetail
force-pushed
the
revisit-orclazy-debug-tests
branch
from
ccb0be8
to
7a4da62
Compare
There was a problem hiding this comment.
Following up from #76244, this patch re-enables one of the OrcLazy debug tests on macOS. Previously these tests were forcing in-memory objects to ELF format. Now they use the native format. As noted inline, the debug-objects.ll test doesn't work for Mach-O yet. @aeubanks Once this lands, please let me know if this causes issues on your bots.
| ; CHECK: -: file format elf64-x86-64 | ||
| ; TODO: Synthesized Mach-O objects error out with: | ||
| ; truncated or malformed object (offset field of section 8 in | ||
| ; LC_SEGMENT_64 command 0 extends past the end of the file) |
There was a problem hiding this comment.
@lhames I guess this could be fixed in the Mach-O debugger support plugin? Then we can re-enable this test as well.
|
Failed tests were all in MLIR and unrelated. The review was up for 2 weeks and didn't get feedback. This cleanup seems worth having in the upcoming release. I am happy to discuss potential questions post-commit. |
Reverts #76822 This fails to build with gcc 7.5: ``` llvm/tools/lli/lli.cpp:1087:16: error: could not convert ‘Obj’ from ‘std::unique_ptr<llvm::MemoryBuffer>’ to ‘llvm::Expected<std::unique_ptr<llvm::MemoryBuffer> >’ return Obj; ^~~ ```
|
Hey @weliveindetail : this broke the gcc 7.5 bot, I reverted in #79055 ; feel free to reland with a fix! |
|
Thanks for reverting. I will have look. |
|
GCC-7 was right, that there was a missing |
Integrate in-memory debug-info dumps into the
--orc-lazy-debugcommand-line option instead of exposing built-in functions to be called from JITed code. This reduces overall amount of code (removingExecutionUtils.cpp) and seems cleaner anyway.All existing items of
OrcDumpKindwork on IR level and run in the IR-transform step of the JIT. The newly addedDumpDebugDescriptorandDumpDebugObjectsmust run after debug-registration and thus are deferred to the Object-transform step of the JIT. This separation is the major side-effect of the patch.