Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llvm][doc] Fix typo in documenation #76836

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

alekuz01
Copy link
Contributor

@alekuz01 alekuz01 commented Jan 3, 2024

Fix for #71941

@alekuz01 alekuz01 requested a review from mgabka January 3, 2024 17:17
@alekuz01 alekuz01 self-assigned this Jan 3, 2024
Copy link

github-actions bot commented Jan 3, 2024

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

Copy link
Contributor

@mgabka mgabka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however please check what is the process now when working on github issues and reviews via github, in the past when issue was referenced in commit message it was getting closed after merging phabricator patch automatically, not sure if there is anything like that now.

Also I would also suggest to use a different title for the commit message, perhaps:

[NFC] Fix typo in documentation in CMake.rst

and then in the description mention the guthub issue

@alekuz01
Copy link
Contributor Author

alekuz01 commented Jan 3, 2024

@mgabka thank you for the feedback. should I amend message?

@alekuz01 alekuz01 changed the title Issue-71941 Fix typo in documenation [llvm][doc] Fix typo in documenation Jan 4, 2024
@alekuz01 alekuz01 merged commit 3fd081f into llvm:main Jan 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants