Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BOLT] Use continuous output addresses in delta encoding in BAT #76904

Merged
merged 16 commits into from
Jan 18, 2024
Merged

[BOLT] Use continuous output addresses in delta encoding in BAT #76904

merged 16 commits into from
Jan 18, 2024

Conversation

aaupov
Copy link
Contributor

@aaupov aaupov commented Jan 4, 2024 •
edited

Make output function addresses be delta-encoded wrt last offset in the
previous function. This reduces the deltas in function start addresses.

Test Plan:
Reduces BAT section size to:

  • large binary: 12218860 bytes (0.32x original),
  • medium binary: 1606580 bytes (0.27x original),
  • small binary: 404 bytes (0.28x original),

@aaupov
[𝘀𝗽𝗿] changes to main this commit is based on
2027bc7 
Created using spr 1.3.4

[skip ci]
@aaupov
[𝘀𝗽𝗿] initial version
b4a5951 
Created using spr 1.3.4
@aaupov
[𝘀𝗽𝗿] changes introduced through rebase
ed540bb 
Created using spr 1.3.4

[skip ci]
@aaupov
Updated BAT.md
1e10904 
Created using spr 1.3.4
@aaupov
[𝘀𝗽𝗿] changes introduced through rebase
7d122a9 
Created using spr 1.3.4

[skip ci]
@aaupov
rebase
b991fd4 
Created using spr 1.3.4
@aaupov
[𝘀𝗽𝗿] changes introduced through rebase
177bd0e 
Created using spr 1.3.4

[skip ci]
@aaupov
rebase
9389217 
Created using spr 1.3.4
@aaupov
[𝘀𝗽𝗿] changes introduced through rebase
dae5375 
Created using spr 1.3.4

[skip ci]
@aaupov
rebase
7d92d19 
Created using spr 1.3.4
@aaupov
[𝘀𝗽𝗿] changes introduced through rebase
5927b10 
Created using spr 1.3.4

[skip ci]
@aaupov
Rename Input/OutputAddr to Offset in BAT.md
2ed9908 
Created using spr 1.3.4
@aaupov
[𝘀𝗽𝗿] changes introduced through rebase
295ab60 
Created using spr 1.3.4

[skip ci]
@aaupov
Addressed feedback in #76903
92a3a26 
Created using spr 1.3.4
rafaelauler
rafaelauler approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@rafaelauler rafaelauler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaupov aaupov changed the base branch from users/aaupov/spr/main.bolt-use-continuous-output-addresses-in-delta-encoding-in-bat to main January 18, 2024 19:58
@aaupov aaupov changed the base branch from main to users/aaupov/spr/main.bolt-use-continuous-output-addresses-in-delta-encoding-in-bat January 18, 2024 20:00
PortalPete and others added 2 commits January 18, 2024 12:25
@PortalPete @aaupov
[𝘀𝗽𝗿] changes introduced through rebase
8b44e9c 
Created using spr 1.3.4

[skip ci]
@aaupov
rebase
5072b4f 
Created using spr 1.3.4
@aaupov aaupov changed the base branch from users/aaupov/spr/main.bolt-use-continuous-output-addresses-in-delta-encoding-in-bat to main January 18, 2024 21:49
@aaupov aaupov merged commit 8f1d94a into main Jan 18, 2024
6 of 7 checks passed
@aaupov aaupov deleted the users/aaupov/spr/bolt-use-continuous-output-addresses-in-delta-encoding-in-bat branch January 18, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelauler rafaelauler rafaelauler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aaupov @rafaelauler @PortalPete