[BOLT] Write and parse BF/BB hashes in BAT #76907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
rafaelauler
reviewed
Jan 25, 2024
| LLVM_DEBUG(dbgs() << "BB " << BB.getName() << "\n"); | ||
| LLVM_DEBUG(dbgs() << " Key: " << Twine::utohexstr(BBOutputOffset) | ||
| << " Val: " << Twine::utohexstr(BBInputOffset) << "\n"); | ||
| LLVM_DEBUG(dbgs() << "BB " << BB.getName() << "\n" |
There was a problem hiding this comment.
So you're not using the basic block hash anywhere, other than printing it to debug output?
There was a problem hiding this comment.
Not in this diff. Hashes will be output to YAML in follow up diffs starting with #76910.
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
rafaelauler
approved these changes
Mar 20, 2024
aaupov
changed the base branch from
users/aaupov/spr/main.bolt-write-and-parse-bfbb-hashes-in-bat
to
main
aaupov
deleted the
users/aaupov/spr/bolt-write-and-parse-bfbb-hashes-in-bat
branch
chencha3
pushed a commit
to chencha3/llvm-project
that referenced
this pull request
Mar 23, 2024
This increases BAT section size to: - large binary: 34832976 bytes (0.90x original), - medium binary: 3586800 bytes (0.60x original), - small binary: 816 bytes (0.57x original). Test Plan: Updated bolt/test/X86/bolt-address-translation.test Reviewers: rafaelauler, dcci, ayermolo, maksfb Reviewed By: rafaelauler Pull Request: llvm#76907
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases BAT section size to:
Test Plan: Updated bolt/test/X86/bolt-address-translation.test