[LLD] [MinGW] Sync --thinlto-cache-dir option details with ELF #77010
Conversation
Disallow using the form with a separate argument, "--thinlto-cache-dir dir", allow only the one with equals, "--thintlo-cache-dir=dir". This is the only form that actually was tested when this was added in f794808, and matches the ELF side, where only the form with an equals is supported (and this was also the case at the time when this option was added to the MinGW linker).
|
@llvm/pr-subscribers-platform-windows @llvm/pr-subscribers-lld Author: Martin Storsjö (mstorsjo) ChangesDisallow using the form with a separate argument, Full diff: https://github.com/llvm/llvm-project/pull/77010.diff 1 Files Affected:
diff --git a/lld/MinGW/Options.td b/lld/MinGW/Options.td
index d4a49cdbd53593..d8471d5a7bc9ed 100644
--- a/lld/MinGW/Options.td
+++ b/lld/MinGW/Options.td
@@ -186,8 +186,8 @@ def appcontainer: F<"appcontainer">, HelpText<"Set the appcontainer flag in the
defm delayload: Eq<"delayload", "DLL to load only on demand">;
defm mllvm: EqNoHelp<"mllvm">;
defm pdb: Eq<"pdb", "Output PDB debug info file, chosen implicitly if the argument is empty">;
-defm thinlto_cache_dir: EqLong<"thinlto-cache-dir",
- "Path to ThinLTO cached object file directory">;
+def thinlto_cache_dir: JJ<"thinlto-cache-dir=">,
+ HelpText<"Path to ThinLTO cached object file directory">;
defm Xlink : Eq<"Xlink", "Pass <arg> to the COFF linker">, MetaVarName<"<arg>">;
defm guard_cf : B<"guard-cf", "Enable Control Flow Guard" ,
"Do not enable Control Flow Guard (default)">;
|
|
The patch looks good to me, but should it have a test case? I guess it doesn't matter much in this case, but it also seems easy enough to have one. |
Not sure we explicitly want to have a test to disallow specific spellings of all potential options (unless we have a real world case for that) - the main reason here is that when looking into adding more options from lld/ELF into lld/MinGW, I noticed this discrepancy - which seems unintentional (all uses of the option use this one single form). |
…77010) Disallow using the form with a separate argument, "--thinlto-cache-dir dir", allow only the one with equals, "--thintlo-cache-dir=dir". This is the only form that actually was tested when this was added in f794808, and matches the ELF side, where only the form with an equals is supported (and this was also the case at the time when this option was added to the MinGW linker).
Disallow using the form with a separate argument,
"--thinlto-cache-dir dir", allow only the one with equals, "--thintlo-cache-dir=dir". This is the only form that actually was tested when this was added in
f794808, and matches the ELF side, where only the form with an equals is supported (and this was also the case at the time when this option was added to the MinGW linker).