Allow LLVM_FAULTMAPS section to be put after the DWARF section.

[shamithoke]

Presently, the DWARF section is expected to be the last section barring few sections as exceptions.
As I understand, the requirement to keep DWARF section at the end is to enforce that _text section should not go after the DWARF section.
Adding other sections such LLVM FAULTMAPS section after DWARF can be permitted.

[github-actions]

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

[llvmbot]

@llvm/pr-subscribers-mc

Author: None (shamithoke)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/77107.diff

1 Files Affected:

• (modified) llvm/lib/MC/MCMachOStreamer.cpp (+4)

diff --git a/llvm/lib/MC/MCMachOStreamer.cpp b/llvm/lib/MC/MCMachOStreamer.cpp
index d7d343f15eaa61..61ab944ae44fbb 100644
--- a/llvm/lib/MC/MCMachOStreamer.cpp
+++ b/llvm/lib/MC/MCMachOStreamer.cpp
@@ -160,6 +160,10 @@ static bool canGoAfterDWARF(const MCSectionMachO &MSec) {
     return true;
   if (SegName == "__LLVM" && SecName == "__cg_profile")
     return true;
+
+  if (SegName == "__LLVM_FAULTMAPS" && SecName == "__llvm_faultmaps")
+    return true;
+
   return false;
 }
 

[shamithoke]

@danilaml

[shamithoke]

@espindola

[espindola]

I no longer work on llvm: https://lists.llvm.org/pipermail/llvm-dev/2018-May/122922.html shamithoke ***@***.***> writes:

…

@espindola -- Reply to this email directly or view it on GitHub: #77107 (comment) You are receiving this because you were mentioned. Message ID: ***@***.***>

[dwblaikie]

Could you provide more details (ideally details that will go into the commit message) on the motivation for this change (possible other folks on this review understand the implications of this change and the motivation is obvious, but I'm not as familiar - and seems like good details to include to make this more transparent)

[shamithoke]

ping