[GitHub] Fix slow sccache install on macOS by upgrading macOS version #77165
Conversation
|
@llvm/pr-subscribers-github-workflow Author: Craig Hesling (linux4life798) ChangesThe "Setup ccache" step on macOS-11 builds takes between 15 to 20 mins, whereas this step takes a less than 10 seconds on other runners. The bulk of this time is spent at the "Install sccache" step, where brew emits warnings like "Warning: You are using macOS 11." and "We (and Apple) do not provide support for this old version...". Bumping the version of macOS greatly decreases this cache setup time to about 20 seconds. Furthermore, it seems like it is speeding up general build times, too. It appears that actions/runner-images#5900 has been resolved or obsoleted, so I do not believe Full diff: https://github.com/llvm/llvm-project/pull/77165.diff 1 Files Affected:
diff --git a/.github/workflows/llvm-project-tests.yml b/.github/workflows/llvm-project-tests.yml
index 02b1ab75e960ec..e8bdffc2293916 100644
--- a/.github/workflows/llvm-project-tests.yml
+++ b/.github/workflows/llvm-project-tests.yml
@@ -34,9 +34,7 @@ on:
type: string
# Use windows-2019 due to:
# https://developercommunity.visualstudio.com/t/Prev-Issue---with-__assume-isnan-/1597317
- # We're using a specific version of macOS due to:
- # https://github.com/actions/virtual-environments/issues/5900
- default: '["ubuntu-latest", "windows-2019", "macOS-11"]'
+ default: '["ubuntu-latest", "windows-2019", "macOS-latest"]'
concurrency:
# Skip intermediate builds: always.
|
|
@tstellar, is there any way to confirm that the issue mentioned above is resolved or obsolete? |
You can try removing the workaround and see if it still builds. |
linux4life798
force-pushed
the
fix-slow-macOS-sccache-install
branch
from
b9800f2
to
eb38995
Compare
|
Test run with https://github.com/linux4life798/llvm-project/actions/runs/7428652707/job/20216260090 |
|
It looks like we are building properly on macOS-12 without the Here is another test run using
https://github.com/linux4life798/llvm-project/actions/runs/7428836371/job/20216662446 |
The "Setup ccache" step on macOS-11 builds takes between 15 to 20 mins, whereas this step takes a less than 10 seconds on other runners. The bulk of this time is spent at the "Install sccache" step, where brew emits warnings like "Warning: You are using macOS 11." and "We (and Apple) do not provide support for this old version...". Bumping the version of macOS greatly decreases this cache setup time to about 20 seconds. Furthermore, it seems like it is speeding up general build times, too. It appears that actions/runner-images#5900 has been resolved, so I do not believe we need to lock macOS to 11 anymore.
Remove the workaround for actions/runner-images#5900, which seems to be resolved.
linux4life798
force-pushed
the
fix-slow-macOS-sccache-install
branch
from
eb38995
to
a00da51
Compare
|
I forgot to change the |
|
@tstellar, I don't have merge rights to this repo. What is the protocol for merging approved changed? I have a few PRs that have been approved, but not merged. |
|
@linux4life798 Which other PRs do you need merged? |
|
🙏 thank you! The local commit stack was getting pretty deep. |
|
It looks like there is some sccache / hendrikmuhs/ccache-action issue with macOS-12. I explained the problem in hendrikmuhs/ccache-action#174, but basically macOS-12 builds will appears to restore their cache correctly, but the build doesn't appear to be using the cache (really slow), and then it fails to get the cache stats at the end of the run. This last part causes the cache to not be saved. I'm running an experiment with macOS-11 and macOS-12 to see if the version bump alone triggers this: |
|
Hmm. It looks like macOS-11 does not see this cache issue. It worth noting that builds succeed on macOS-11 even with the I also tried to see if there was newer version of hendrikmuhs/ccache-action, but it looks like we are already using the newest version (the v1 tag was updated to the latest tag). I am running another experiment to see if an older version of hendrikmuhs/ccache-action still shows this cache issue, but in the meantime, I think we should just revert the commit for this PR (602c8fa). |
… version (llvm#77165)" This reverts commit 602c8fa, due to an sccache issue seen on larger builds using macOS-12 runners. The issue is documented in in the following issue: hendrikmuhs/ccache-action#174 The original PR is the following: llvm#77165
… version (#77165)" (#77270) This reverts commit 602c8fa, due to an sccache issue seen on larger builds using macOS-12 runners. The issue is documented in in the following issue: hendrikmuhs/ccache-action#174 The original PR is the following: #77165
…llvm#77165) The "Setup ccache" step on macOS-11 builds takes between 15 to 20 mins, whereas this step takes a less than 10 seconds on other runners. The bulk of this time is spent at the "Install sccache" step, where brew emits warnings like "Warning: You are using macOS 11." and "We (and Apple) do not provide support for this old version...". Bumping the version of macOS greatly decreases this cache setup time to about 20 seconds. Furthermore, it seems like it is speeding up general build times, too. It appears that actions/runner-images#5900 has been resolved or obsoleted, so I do not believe we need to lock macOS to 11 anymore.
… version (llvm#77165)" (llvm#77270) This reverts commit 602c8fa, due to an sccache issue seen on larger builds using macOS-12 runners. The issue is documented in in the following issue: hendrikmuhs/ccache-action#174 The original PR is the following: llvm#77165
The "Setup ccache" step on macOS-11 builds takes between 15 to 20 mins, whereas this step takes a less than 10 seconds on other runners. The bulk of this time is spent at the "Install sccache" step, where brew emits warnings like "Warning: You are using macOS 11." and "We (and Apple) do not provide support for this old version...".
Bumping the version of macOS greatly decreases this cache setup time to about 20 seconds. Furthermore, it seems like it is speeding up general build times, too.
It appears that actions/runner-images#5900 has been resolved or obsoleted, so I do not believe
we need to lock macOS to 11 anymore.