Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[asan] Enable StackSafetyAnalysis by default #77210

Merged
merged 2 commits into from
Jan 10, 2024
Merged

[asan] Enable StackSafetyAnalysis by default #77210

merged 2 commits into from
Jan 10, 2024

Commits on Jan 7, 2024

  1. [asan] Enable StackSafetyAnalysis by default 

    StackSafetyAnalysis determines whether stack-allocated variables are
safe from memory access bugs and allows removing certain unneeded
instrumentations.
(hwasan enables StackSafetyAnalysis in https://reviews.llvm.org/D108381)

Test updates:

* asan-stack-safety.ll: test the -asan-use-stack-safety=1 default
* lifetime-uar-uas.ll: switch to an indexed store to prevent
  StackSafetyAnalysis from optimizing out instrumentation for %c
* alloca_vla_interact.cpp: add a load to prevent StackSafetyAnalysis
  from optimizing out `__asan_alloca_poison` for the VLA `array`
* scariness_score_test.cpp: add -asan-use-stack-safety=0 to make a load
  of a `__asan_poison_memory_region`-poisoned local variable fail as
  intended.
* other .ll tests: add -asan-use-stack-safety=0

Pull Request: #77210
    @MaskRay
    MaskRay committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    af33fcd View commit details
    Browse the repository at this point in the history

  2. Test spr diff with a clean repo https://discourse.llvm.org/t/using-ge… 

    …tcord-spr/76097

Created using spr 1.3.4
    @MaskRay
    MaskRay committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    ae78982 View commit details
    Browse the repository at this point in the history