Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mlir][arith] Add overflow flags support to arith ops #77211

Merged
merged 7 commits into from Jan 9, 2024
Merged

[mlir][arith] Add overflow flags support to arith ops #77211

merged 7 commits into from Jan 9, 2024

Commits on Jan 6, 2024

  1. [mlir][arith] Add overflow flags support to arith ops 

    Add overflow flags support to the following ops:
* `arith.addi`
* `arith.subi`
* `arith.muli`

Tablegen canonicalization patterns updated to always drop flags, proper support with tests will be added later.

Updated LLVMIR translation as part of this commit as it currenly written in a way that it will crash when new attributes added to arith ops otherwise.
    @yi-wu-arm @Hardcode84
    yi-wu-arm authored and Hardcode84 committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    0c1f04d View commit details
    Browse the repository at this point in the history

  2. fix python test

    @Hardcode84
    Hardcode84 committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    82eeda0 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2024

  1. Update docs and comments

    @Hardcode84
    Hardcode84 committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    3d09907 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Update docs, Arith_IntBinaryOpWithOverflowFlags, cleanup hasFolder/ha… 

    …sCanonicalizer
    @Hardcode84
    Hardcode84 committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    4c6f3ac View commit details
    Browse the repository at this point in the history

  2. Canonicalizations comment

    @Hardcode84
    Hardcode84 committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    c36ae9d View commit details
    Browse the repository at this point in the history

  3. better comment

    @Hardcode84
    Hardcode84 committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    b69c5b8 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. formatting

    @Hardcode84
    Hardcode84 committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    750e0f7 View commit details
    Browse the repository at this point in the history