Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to meger strings used by metadata #77364

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

scui-ibm
Copy link
Contributor

@scui-ibm scui-ibm commented Jan 8, 2024

Currently if the merged string is used by metadata, its metadata uses are not replaced if the string is merged. This is to add code support for the metadata use replacement.

@scui-ibm
Copy link
Contributor Author

gentle ping - any comments/approval?

Copy link
Contributor

@stefanp-ibm stefanp-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you for fixing this. I didn't think of the metadata and I didn't realize that the code would just replace the global with null in the metadata.

@scui-ibm scui-ibm merged commit e278c67 into llvm:main Jan 26, 2024
4 of 5 checks passed
@scui-ibm scui-ibm deleted the merge-string-used-by-metadata branch January 31, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants