[llvm/unittests] Reset the IsSSA property when using finalizeBundle() #77469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsenm
reviewed
Jan 9, 2024
| @@ -156,6 +156,7 @@ static void testHandleMoveIntoNewBundle(MachineFunction &MF, LiveIntervals &LIS, | |||
|
|
|||
| // Build bundle | |||
| finalizeBundle(MBB, I, std::next(ToInstr.getIterator())); | |||
| MF.getProperties().reset(MachineFunctionProperties::Property::IsSSA); | |||
There was a problem hiding this comment.
The test probably shouldn't have had IsSSA in the first place
There was a problem hiding this comment.
IsSSA is computed by the MIRParser
There was a problem hiding this comment.
Right, which is buggy. It tries to guess but I think the MIR parser needs an explicit IsSSA property.
There was a problem hiding this comment.
By buggy I mean assume SSA by default runs into these sorts of issues. Tests have a definite SSAness which it gets wrong. You could just as well clear this before finalizeBundle
There was a problem hiding this comment.
I guess @yashssh ran into a similar situation once and was trying to fix the default isSSA property assumed by MIRParser. Wasn't that ever landed?
arsenm
approved these changes
Jan 9, 2024
arsenm
approved these changes
Jan 9, 2024
justinfargnoli
pushed a commit
to justinfargnoli/llvm-project
that referenced
this pull request
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.