[TableGen] Support non-def operators in !getdagop #77531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francisvm
requested review from
Paul-C-Anagnostopoulos,
Artem-B,
anemet,
fpetrogalli,
statham-arm and
wangpc-pp
Artem-B
approved these changes
Jan 9, 2024
fpetrogalli
approved these changes
Jan 10, 2024
`!getdagop` expects the dag operator to be a def, and errors out if it's not. While that's true in most cases, when multiclasses are involved, the late resolution of the dag operator can result in it not being a def yet, but still have a proper type, wich is required to check against the optional parameter Ty in `!getdagop<Ty>`. e.g, in the following dag: ``` (!cast<TestInstruction>(TestInstructionAndPattern::NAME) foo) ``` the operator is a UnOpInit, but all we need here is to check its type. This fixes a bug where !getdagop is used to query the dag operator that is dependent on the multiclass, which is not yet resolved to a def. Once the folding is performed, the field becomes a record that can be queried.
francisvm
force-pushed
the
tablegen-getdagop-fix
branch
from
e87a0a4
to
76e2126
Compare
justinfargnoli
pushed a commit
to justinfargnoli/llvm-project
that referenced
this pull request
Jan 28, 2024
`!getdagop` expects the dag operator to be a def, and errors out if it's not. While that's true in most cases, when multiclasses are involved, the late resolution of the dag operator can result in it not being a def yet, but still have a proper type, wich is required to check against the optional parameter Ty in `!getdagop<Ty>`. e.g, in the following dag: ``` (!cast<TestInstruction>(TestInstructionAndPattern::NAME) foo) ``` the operator is a UnOpInit, but all we need here is to check its type. This fixes a bug where !getdagop is used to query the dag operator that is dependent on the multiclass, which is not yet resolved to a def. Once the folding is performed, the field becomes a record that can be queried.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!getdagopexpects the dag operator to be a def, and errors out if it's not.While that's true in most cases, when multiclasses are involved, the late resolution of the dag operator can result in it not being a def yet, but still have a proper type, wich is required to check against the optional parameter Ty in
!getdagop<Ty>.e.g, in the following dag:
the operator is a UnOpInit, but all we need here is to check its type.
This fixes a bug where !getdagop is used to query the dag operator that is dependent on the multiclass, which is not yet resolved to a def. Once the folding is performed, the field becomes a record that can be queried.