Commits on Jan 9, 2024

1. [lldb] [Mach-O] don't strip the end of the "kern ver str" LC_NOTE …

   The "kern ver str" LC_NOTE gives lldb a kernel version string --
   with a UUID and/or a load address (stext) to load it at.  The LC_NOTE
   specifies a size of the identifier string in bytes. In
   ObjectFileMachO::GetIdentifierString, I copy that number of bytes
   into a std::string, and in case there were additional nul characters
   at the end of the sting for padding reasons, I tried to shrink the
   std::string to not include these extra nul's.
   
   However, I did this resizing without handling the case of an empty
   identifier string.  I don't know why any corefile creator would do
   that, but of course at least one does.  This patch removes the
   resizing altogether; I was solving something that hasn't ever shown
   to be a problem.  I also added a test case for this, to check that
   lldb doesn't crash when given one of these corefiles.
   
   rdar://120390199

   

   jasonmolenda committed Jan 9, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 76a3879
   • Browse repository at this point

   Copy the full SHA

   76a3879 View commit details

   Browse the repository at this point in the history