Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libcxx] renames local variable to avoid shadowing werror #77672

Merged
merged 2 commits into from Jan 10, 2024
Merged

[libcxx] renames local variable to avoid shadowing werror #77672

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c3a710
[libcxx] renames local variable to avoid shadowing werror
cjdb Jan 10, 2024
4fd5e77
Apply suggestions from code review
ldionne Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions libcxx/test/std/ranges/range.adaptors/range.join/range.join.sentinel/ctor.other.pass.cpp
View file
Open in desktop
Expand Up @@ -71,10 +71,10 @@ constexpr bool test() {
BufferView<forward_iterator<const Inner*>, sentinel_wrapper<forward_iterator<const Inner*>>,
bidirectional_iterator<Inner*>, sentinel_wrapper<bidirectional_iterator<Inner*>>>;
using JoinView = std::ranges::join_view<ConstInconvertibleOuter>;
using sentinel = std::ranges::sentinel_t<JoinView>;
using sentinel_t = std::ranges::sentinel_t<JoinView>;
using const_sentinel = std::ranges::sentinel_t<const JoinView>;
ldionne marked this conversation as resolved.
Show resolved Hide resolved
static_assert(!std::constructible_from<sentinel, const_sentinel>);
static_assert(!std::constructible_from<const_sentinel, sentinel>);
static_assert(!std::constructible_from<sentinel_t, const_sentinel>);
static_assert(!std::constructible_from<const_sentinel, sentinel_t>);
ldionne marked this conversation as resolved.
Show resolved Hide resolved
}
return true;
}
Expand Down