Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lto] Add minimum macos sdk requirement to test #77695

Closed
wants to merge 2 commits into from

Conversation

Caslyn
Copy link
Contributor

@Caslyn Caslyn commented Jan 10, 2024

No description provided.

@Caslyn Caslyn self-assigned this Jan 10, 2024
@Caslyn Caslyn marked this pull request as ready for review January 10, 2024 23:42
Caslyn referenced this pull request Jan 10, 2024
At the moment, lto-discard-value-names isn't handled properly by libLTO.
@Caslyn Caslyn requested a review from fhahn January 10, 2024 23:42
@fhahn
Copy link
Contributor

fhahn commented Jan 11, 2024

Hmmm, did you try this with a newer SDK to confirm it works as expected or is possible that it now just doesn't run?

Do you know what SDK version the failing system has? The option handling is done by libLTO built from source, so I'd be surprised if that doesn't get passed through

@Caslyn Caslyn closed this Jan 29, 2024
@Caslyn Caslyn deleted the test-discard-mac branch January 29, 2024 17:57
@fhahn
Copy link
Contributor

fhahn commented Jan 29, 2024

Thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants