Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libc++][NFC] Make AssertionInfoMatcher::CheckMessageMatches Stricter #77721

Merged
merged 3 commits into from
Jan 12, 2024
Merged

[libc++][NFC] Make AssertionInfoMatcher::CheckMessageMatches Stricter #77721

merged 3 commits into from
Jan 12, 2024

Commits on Jan 11, 2024

  1. [libc++][NFC] Make AssertionInfoMatcher::CheckMessageMatches Stricter 

    Rather than allow for a message to be considered a match for the actual
assertion if it is anywhere in the assertion text, make sure that the
expected and the actual assertion are identical.
    @hawkinsw
    hawkinsw committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    ede4846 View commit details
    Browse the repository at this point in the history

  2. fixup! [libc++][NFC] Make AssertionInfoMatcher::CheckMessageMatches S… 

    …tricter

Fix a few locations where matches were not precise.
    @hawkinsw
    hawkinsw committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    0d572b2 View commit details
    Browse the repository at this point in the history

  3. fixup! [libc++][NFC] Make AssertionInfoMatcher::CheckMessageMatches S… 

    …tricter

Remove unrelated change.
    @hawkinsw
    hawkinsw committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    85ce641 View commit details
    Browse the repository at this point in the history