Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lldb][ValueObject][NFC] Remove unused parameter to ReadPointedString #77919

Merged
merged 1 commit into from Jan 12, 2024

Conversation

Michael137
Copy link
Member

@Michael137 Michael137 commented Jan 12, 2024

All its usages were removed in 2206b48d6ddabad61979fa69ba09e6b6fb19b0b2.

@llvmbot
Copy link
Collaborator

llvmbot commented Jan 12, 2024

@llvm/pr-subscribers-lldb

Author: Michael Buch (Michael137)

Changes

All its usages were removed in 2206b48d6ddabad61979fa69ba09e6b6fb19b0b2.


Full diff: https://github.com/llvm/llvm-project/pull/77919.diff

2 Files Affected:

  • (modified) lldb/include/lldb/Core/ValueObject.h (+1-2)
  • (modified) lldb/source/Core/ValueObject.cpp (+1-1)
diff --git a/lldb/include/lldb/Core/ValueObject.h b/lldb/include/lldb/Core/ValueObject.h
index 3f8005ba696ce8..dec1c7b237ac27 100644
--- a/lldb/include/lldb/Core/ValueObject.h
+++ b/lldb/include/lldb/Core/ValueObject.h
@@ -670,8 +670,7 @@ class ValueObject {
 
   std::pair<size_t, bool>
   ReadPointedString(lldb::WritableDataBufferSP &buffer_sp, Status &error,
-                    uint32_t max_length = 0, bool honor_array = true,
-                    lldb::Format item_format = lldb::eFormatCharArray);
+                    uint32_t max_length = 0, bool honor_array = true);
 
   virtual size_t GetPointeeData(DataExtractor &data, uint32_t item_idx = 0,
                                 uint32_t item_count = 1);
diff --git a/lldb/source/Core/ValueObject.cpp b/lldb/source/Core/ValueObject.cpp
index b2a6d9412ab40b..a5d155d3c6675f 100644
--- a/lldb/source/Core/ValueObject.cpp
+++ b/lldb/source/Core/ValueObject.cpp
@@ -814,7 +814,7 @@ static bool CopyStringDataToBufferSP(const StreamString &source,
 std::pair<size_t, bool>
 ValueObject::ReadPointedString(lldb::WritableDataBufferSP &buffer_sp,
                                Status &error, uint32_t max_length,
-                               bool honor_array, Format item_format) {
+                               bool honor_array) {
   bool was_capped = false;
   StreamString s;
   ExecutionContext exe_ctx(GetExecutionContextRef());

@Michael137 Michael137 merged commit 844a8dc into llvm:main Jan 12, 2024
5 checks passed
justinfargnoli pushed a commit to justinfargnoli/llvm-project that referenced this pull request Jan 28, 2024
…llvm#77919)

All its usages were removed in
`2206b48d6ddabad61979fa69ba09e6b6fb19b0b2`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants