Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder fields for better packing #77998

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

urnathan
Copy link
Contributor

I noticed this structure's fields are poorly ordered when considering padding. This reordering reduces the size from 56 bytes to 40 bytes (on LP64).

Copy link

github-actions bot commented Jan 12, 2024

✅ With the latest revision this PR passed the C/C++ code formatter.

I noticed this structure's fields are poorly ordered when considering
padding.  This reordering reduces the size from 56 bytes to 40 bytes
(on LP64).
I noticed this structure's fields are poorly ordered when considering
padding.  This reordering reduces the size from 56 bytes to 40 bytes
(on LP64).
@urnathan urnathan marked this pull request as ready for review January 29, 2024 16:26
Copy link
Contributor

@maksfb maksfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for the late review, just noticed this.

@urnathan urnathan merged commit 66f0984 into llvm:main Mar 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants