[libunwind] Move errno.h and signal.h includes under the block where they're needed #78054
Conversation
…they're needed Commit fc1c478 added includes of <signal.h> and <errno.h> to UnwindCursor.hpp. The library previously built on platforms where these headers are not provided. These headers should be included only in the case where they are actually needed, i.e. on Linux.
|
@llvm/pr-subscribers-libunwind Author: Louis Dionne (ldionne) ChangesCommit fc1c478 added includes of <signal.h> and <errno.h> to UnwindCursor.hpp. The library previously built on platforms where these headers are not provided. These headers should be included only in the case where they are actually needed, i.e. on Linux. Full diff: https://github.com/llvm/llvm-project/pull/78054.diff 1 Files Affected:
diff --git a/libunwind/src/UnwindCursor.hpp b/libunwind/src/UnwindCursor.hpp
index 8517d328bd058b..7753936a5894a3 100644
--- a/libunwind/src/UnwindCursor.hpp
+++ b/libunwind/src/UnwindCursor.hpp
@@ -12,8 +12,6 @@
#define __UNWINDCURSOR_HPP__
#include "cet_unwind.h"
-#include <errno.h>
-#include <signal.h>
#include <stdint.h>
#include <stdio.h>
#include <stdlib.h>
@@ -35,6 +33,8 @@
#if defined(_LIBUNWIND_TARGET_LINUX) && \
(defined(_LIBUNWIND_TARGET_AARCH64) || defined(_LIBUNWIND_TARGET_RISCV) || \
defined(_LIBUNWIND_TARGET_S390X))
+#include <errno.h>
+#include <signal.h>
#include <sys/syscall.h>
#include <sys/uio.h>
#include <unistd.h>
|
|
By the way, I noticed that you checked the "hide my email address" Github feature, which leads to your commits being authored as |
|
Done! Thanks for the heads up on the email. I'm not too familiar with the GitHub workflow still. Also thanks for this fix PR. |
…they're needed (llvm#78054) Commit fc1c478 added includes of <signal.h> and <errno.h> to UnwindCursor.hpp. The library previously built on platforms where these headers are not provided. These headers should be included only in the case where they are actually needed, i.e. on Linux.
Commit fc1c478 added includes of <signal.h> and <errno.h> to UnwindCursor.hpp. The library previously built on platforms where these headers are not provided. These headers should be included only in the case where they are actually needed, i.e. on Linux.