Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SystemZ] Don't crash on undef source in shouldCoalesce() #78056

Merged
merged 1 commit into from
Jan 15, 2024
Merged

[SystemZ] Don't crash on undef source in shouldCoalesce() #78056

merged 1 commit into from
Jan 15, 2024

Conversation

JonPsson1
Copy link
Contributor

SystemZRegisterInfo::shouldCoalesce() has to be able to handle an undef source.

uweigand
uweigand approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@uweigand uweigand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonPsson1 JonPsson1 merged commit 3b16d8c into llvm:main Jan 15, 2024
4 of 5 checks passed
@JonPsson1 JonPsson1 deleted the CoaelesceUndef branch January 15, 2024 16:24
@dyung
Copy link
Collaborator

dyung commented Jan 15, 2024

@JonPsson1 The test you added is leaving a .s file around which is causing an unresolved test error on a buildbot because the .s file has no RUN lines:

https://lab.llvm.org/buildbot/#/builders/275/builds/3332

******************** TEST 'LLVM :: CodeGen/SystemZ/regcoal_undefsrc.s' FAILED ********************
Test has no 'RUN:' line
********************

@JonPsson1
Copy link
Contributor Author

@JonPsson1 The test you added is leaving a .s file around which is causing an unresolved test error on a buildbot because the .s file has no RUN lines:

https://lab.llvm.org/buildbot/#/builders/275/builds/3332

******************** TEST 'LLVM :: CodeGen/SystemZ/regcoal_undefsrc.s' FAILED ********************
Test has no 'RUN:' line
********************

Thanks - fixed with e2ce91f.

justinfargnoli pushed a commit to justinfargnoli/llvm-project that referenced this pull request Jan 28, 2024
@JonPsson1 @justinfargnoli
[SystemZ] Don't crash on undef source in shouldCoalesce() (llvm#78056)
7254f2e 
SystemZRegisterInfo::shouldCoalesce() has to be able to handle an undef
source.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uweigand uweigand uweigand approved these changes

Assignees
No one assigned
Labels
backend:SystemZ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JonPsson1 @dyung @uweigand