Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llvm][frontend][offloading] Move clang-linker-wrapper/OffloadWrapper.* to llvm/Frontend/Offloading #78057

Merged
merged 4 commits into from
Jan 15, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion clang/tools/clang-linker-wrapper/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ endif()

add_clang_tool(clang-linker-wrapper
ClangLinkerWrapper.cpp
OffloadWrapper.cpp

DEPENDS
${tablegen_deps}
Expand Down
11 changes: 7 additions & 4 deletions clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@
//
//===---------------------------------------------------------------------===//

#include "OffloadWrapper.h"
#include "clang/Basic/Version.h"
#include "llvm/BinaryFormat/Magic.h"
#include "llvm/Bitcode/BitcodeWriter.h"
#include "llvm/CodeGen/CommandFlags.h"
#include "llvm/Frontend/Offloading/OffloadWrapper.h"
#include "llvm/IR/Constants.h"
#include "llvm/IR/DiagnosticPrinter.h"
#include "llvm/IR/Module.h"
Expand Down Expand Up @@ -906,15 +906,18 @@ wrapDeviceImages(ArrayRef<std::unique_ptr<MemoryBuffer>> Buffers,

switch (Kind) {
case OFK_OpenMP:
if (Error Err = wrapOpenMPBinaries(M, BuffersToWrap))
if (Error Err =
offloading::OffloadWrapper().wrapOpenMPBinaries(M, BuffersToWrap))
return std::move(Err);
break;
case OFK_Cuda:
if (Error Err = wrapCudaBinary(M, BuffersToWrap.front()))
if (Error Err = offloading::OffloadWrapper().wrapCudaBinary(
M, BuffersToWrap.front()))
return std::move(Err);
break;
case OFK_HIP:
if (Error Err = wrapHIPBinary(M, BuffersToWrap.front()))
if (Error Err = offloading::OffloadWrapper().wrapHIPBinary(
M, BuffersToWrap.front()))
return std::move(Err);
break;
default:
Expand Down
28 changes: 0 additions & 28 deletions clang/tools/clang-linker-wrapper/OffloadWrapper.h

This file was deleted.

62 changes: 62 additions & 0 deletions llvm/include/llvm/Frontend/Offloading/OffloadWrapper.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
//===- OffloadWrapper.h --r-------------------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//

#ifndef LLVM_FRONTEND_OFFLOADING_OFFLOADWRAPPER_H
#define LLVM_FRONTEND_OFFLOADING_OFFLOADWRAPPER_H

#include "llvm/ADT/ArrayRef.h"
#include "llvm/IR/Module.h"

namespace llvm {
namespace offloading {
/// Class for embedding and registering offloading images and related objects in
/// a Module.
class OffloadWrapper {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like these should just be free functions and the extra two bits of state here are additional default arguments like you've done with EntryArray.

public:
using EntryArrayTy = std::pair<GlobalVariable *, GlobalVariable *>;

OffloadWrapper(const Twine &Suffix = "", bool EmitSurfacesAndTextures = true)
: Suffix(Suffix.str()), EmitSurfacesAndTextures(EmitSurfacesAndTextures) {
}

/// Wraps the input device images into the module \p M as global symbols and
/// registers the images with the OpenMP Offloading runtime libomptarget.
/// \param EntryArray Optional pair pointing to the `__start` and `__stop`
/// symbols holding the `__tgt_offload_entry` array.
llvm::Error wrapOpenMPBinaries(
llvm::Module &M, llvm::ArrayRef<llvm::ArrayRef<char>> Images,
std::optional<EntryArrayTy> EntryArray = std::nullopt) const;

/// Wraps the input fatbinary image into the module \p M as global symbols and
/// registers the images with the CUDA runtime.
/// \param EntryArray Optional pair pointing to the `__start` and `__stop`
/// symbols holding the `__tgt_offload_entry` array.
llvm::Error
wrapCudaBinary(llvm::Module &M, llvm::ArrayRef<char> Images,
std::optional<EntryArrayTy> EntryArray = std::nullopt) const;

/// Wraps the input bundled image into the module \p M as global symbols and
/// registers the images with the HIP runtime.
/// \param EntryArray Optional pair pointing to the `__start` and `__stop`
/// symbols holding the `__tgt_offload_entry` array.
llvm::Error
wrapHIPBinary(llvm::Module &M, llvm::ArrayRef<char> Images,
std::optional<EntryArrayTy> EntryArray = std::nullopt) const;

protected:
/// Suffix used when emitting symbols. It defaults to the empty string.
std::string Suffix;

/// Whether to emit surface and textures registration code. It defaults to
/// false.
bool EmitSurfacesAndTextures;
Copy link
Contributor

@jhuber6 jhuber6 Jan 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I wasn't sure about this either. I know that CUDA emits these __cudaRegisterSurface calls, but I can't seem to find them in any of the exported libraries. It caused linker errors due to that and I was too lazy to fix it. Wondering if they've been deprecated, maybe @Artem-B knows.

};
} // namespace offloading
} // namespace llvm

#endif // LLVM_FRONTEND_OFFLOADING_OFFLOADWRAPPER_H
6 changes: 6 additions & 0 deletions llvm/include/llvm/Frontend/Offloading/Utility.h
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,12 @@ StructType *getEntryTy(Module &M);
void emitOffloadingEntry(Module &M, Constant *Addr, StringRef Name,
uint64_t Size, int32_t Flags, int32_t Data,
StringRef SectionName);
/// Create a constant struct initializer used to register this global at
/// runtime.
/// \return the constant struct and the global variable holding the symbol name.
std::pair<Constant *, GlobalVariable *>
getOffloadingEntryInitializer(Module &M, Constant *Addr, StringRef Name,
uint64_t Size, int32_t Flags, int32_t Data);

/// Creates a pair of globals used to iterate the array of offloading entries by
/// accessing the section variables provided by the linker.
Expand Down
2 changes: 2 additions & 0 deletions llvm/lib/Frontend/Offloading/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
add_llvm_component_library(LLVMFrontendOffloading
Utility.cpp
OffloadWrapper.cpp

ADDITIONAL_HEADER_DIRS
${LLVM_MAIN_INCLUDE_DIR}/llvm/Frontend
Expand All @@ -9,6 +10,7 @@ add_llvm_component_library(LLVMFrontendOffloading

LINK_COMPONENTS
Core
BinaryFormat
Support
TransformUtils
TargetParser
Expand Down
Loading