Fix 'newline in constant' encoding issue in clangd sources

[cppcloud]

Files within clang-tools-extra/clangd encountered 'newline in constant' errors while compiling with Visual Studio Community 2022 Preview (amd64). The affected files were CodeComplete.h, Diagnostics.cpp, and Selection.cpp.

This issue stems from the MSVC compiler mishandling UTF-8 encoded files without a Byte Order Mark (BOM). To address this, the encoding of these three files has been changed from UTF-8 to UTF-8 with BOM.

Affected files:

• clang-tools-extra/clangd/CodeComplete.h
• clang-tools-extra/clangd/Diagnostics.cpp
• clang-tools-extra/clangd/Selection.cpp

The fix has been verified to resolve the build issues without introducing further problems in other parts of the LLVM project.

[github-actions]

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

[llvmbot]

@llvm/pr-subscribers-clangd

Author: BinVerse (BinVerse)

Changes

Files within clang-tools-extra/clangd encountered 'newline in constant' errors while compiling with Visual Studio Community 2022 Preview (amd64). The affected files were CodeComplete.h, Diagnostics.cpp, and Selection.cpp.

This issue stems from the MSVC compiler mishandling UTF-8 encoded files without a Byte Order Mark (BOM). To address this, the encoding of these three files has been changed from UTF-8 to UTF-8 with BOM.

Affected files:

• clang-tools-extra/clangd/CodeComplete.h
• clang-tools-extra/clangd/Diagnostics.cpp
• clang-tools-extra/clangd/Selection.cpp

The fix has been verified to resolve the build issues without introducing further problems in other parts of the LLVM project.

---

Full diff: https://github.com/llvm/llvm-project/pull/78082.diff

3 Files Affected:

• (modified) clang-tools-extra/clangd/CodeComplete.h (+1-1)
• (modified) clang-tools-extra/clangd/Diagnostics.cpp (+1-1)
• (modified) clang-tools-extra/clangd/Selection.cpp (+1-1)

diff --git a/clang-tools-extra/clangd/CodeComplete.h b/clang-tools-extra/clangd/CodeComplete.h
index a7c1ae95dcbf49..571defc7cf1b8e 100644
--- a/clang-tools-extra/clangd/CodeComplete.h
+++ b/clang-tools-extra/clangd/CodeComplete.h
@@ -1,4 +1,4 @@
-//===--- CodeComplete.h ------------------------------------------*- C++-*-===//
+//===--- CodeComplete.h ------------------------------------------*- C++-*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
diff --git a/clang-tools-extra/clangd/Diagnostics.cpp b/clang-tools-extra/clangd/Diagnostics.cpp
index 704e61b1e4dd79..68ed94262a6bff 100644
--- a/clang-tools-extra/clangd/Diagnostics.cpp
+++ b/clang-tools-extra/clangd/Diagnostics.cpp
@@ -1,4 +1,4 @@
-//===--- Diagnostics.cpp -----------------------------------------*- C++-*-===//
+//===--- Diagnostics.cpp -----------------------------------------*- C++-*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
diff --git a/clang-tools-extra/clangd/Selection.cpp b/clang-tools-extra/clangd/Selection.cpp
index 277cb8769a1b12..1514cf49532504 100644
--- a/clang-tools-extra/clangd/Selection.cpp
+++ b/clang-tools-extra/clangd/Selection.cpp
@@ -1,4 +1,4 @@
-//===--- Selection.cpp ----------------------------------------------------===//
+//===--- Selection.cpp ----------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.