[Support] Give llvm_strlcpy restrict semantics

[AtariDreams]

strlcpy has restrict semantics, so llvm_strlcpy should have them too.

Source: https://man.freebsd.org/cgi/man.cgi?strlcpy

[llvmbot]

@llvm/pr-subscribers-llvm-support

Author: AtariDreams (AtariDreams)

Changes

strlcpy has restrict semantics, so llvm_strlcpy should have them too.

Source: https://man.freebsd.org/cgi/man.cgi?strlcpy

---

Full diff: https://github.com/llvm/llvm-project/pull/78168.diff

2 Files Affected:

• (modified) llvm/lib/Support/regex_impl.h (+1-1)
• (modified) llvm/lib/Support/regstrlcpy.c (+1-1)

diff --git a/llvm/lib/Support/regex_impl.h b/llvm/lib/Support/regex_impl.h
index 8f0c532205edc3..6b780da10e35fe 100644
--- a/llvm/lib/Support/regex_impl.h
+++ b/llvm/lib/Support/regex_impl.h
@@ -99,7 +99,7 @@ size_t	llvm_regerror(int, const llvm_regex_t *, char *, size_t);
 int	llvm_regexec(const llvm_regex_t *, const char *, size_t,
                      llvm_regmatch_t [], int);
 void	llvm_regfree(llvm_regex_t *);
-size_t  llvm_strlcpy(char *dst, const char *src, size_t siz);
+size_t  llvm_strlcpy(char *__restrict dst, const char * __restrict src, size_t siz);
 
 #ifdef __cplusplus
 }
diff --git a/llvm/lib/Support/regstrlcpy.c b/llvm/lib/Support/regstrlcpy.c
index 8b68afdf75f16a..1e55c4f36af7b9 100644
--- a/llvm/lib/Support/regstrlcpy.c
+++ b/llvm/lib/Support/regstrlcpy.c
@@ -26,7 +26,7 @@
  * Returns strlen(src); if retval >= siz, truncation occurred.
  */
 size_t
-llvm_strlcpy(char *dst, const char *src, size_t siz)
+llvm_strlcpy(char *__restrict dst, const char *__restrict src, size_t siz)
 {
 	char *d = dst;
 	const char *s = src;

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.

[nikic]

This looks like an unnecessary change for the sake of change.

[AtariDreams]

This looks like an unnecessary change for the sake of change.

It is just for consistency.

[nikic]

This looks like an unnecessary change for the sake of change.

It is just for consistency.

Consistency with what? This is an utterly unimportant helper used only by the regex implementation, which is imported from a 3rd party to boot. The code is not performance critical, so why would we care to sprinkle about dangerous optimization attributes in its implementation?