[Flang][OpenMP] Remove space before :: in member function definition,… #78205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… NFC The names were ``` bool DataSharingProcessor ::needBarrier() void DataSharingProcessor ::insertBarrier() ``` It seems like clang-format treats those as references to the global namespace instead of separators in a qualified name.
llvmbot
added
flang
|
@llvm/pr-subscribers-flang-openmp Author: Krzysztof Parzyszek (kparzysz) Changes… NFC The names were It seems like clang-format treats those as references to the global namespace instead of separators in a qualified name. Full diff: https://github.com/llvm/llvm-project/pull/78205.diff 1 Files Affected:
diff --git a/flang/lib/Lower/OpenMP.cpp b/flang/lib/Lower/OpenMP.cpp
index 4f7c99a6d2b840..c770d1c60718c3 100644
--- a/flang/lib/Lower/OpenMP.cpp
+++ b/flang/lib/Lower/OpenMP.cpp
@@ -290,7 +290,7 @@ void DataSharingProcessor::collectSymbolsForPrivatization() {
TODO(converter.getCurrentLocation(), "Collapse clause with lastprivate");
}
-bool DataSharingProcessor ::needBarrier() {
+bool DataSharingProcessor::needBarrier() {
for (const Fortran::semantics::Symbol *sym : privatizedSymbols) {
if (sym->test(Fortran::semantics::Symbol::Flag::OmpFirstPrivate) &&
sym->test(Fortran::semantics::Symbol::Flag::OmpLastPrivate))
@@ -299,7 +299,7 @@ bool DataSharingProcessor ::needBarrier() {
return false;
}
-void DataSharingProcessor ::insertBarrier() {
+void DataSharingProcessor::insertBarrier() {
// Emit implicit barrier to synchronize threads and avoid data races on
// initialization of firstprivate variables and post-update of lastprivate
// variables.
|
|
@llvm/pr-subscribers-flang-fir-hlfir Author: Krzysztof Parzyszek (kparzysz) Changes… NFC The names were It seems like clang-format treats those as references to the global namespace instead of separators in a qualified name. Full diff: https://github.com/llvm/llvm-project/pull/78205.diff 1 Files Affected:
diff --git a/flang/lib/Lower/OpenMP.cpp b/flang/lib/Lower/OpenMP.cpp
index 4f7c99a6d2b840..c770d1c60718c3 100644
--- a/flang/lib/Lower/OpenMP.cpp
+++ b/flang/lib/Lower/OpenMP.cpp
@@ -290,7 +290,7 @@ void DataSharingProcessor::collectSymbolsForPrivatization() {
TODO(converter.getCurrentLocation(), "Collapse clause with lastprivate");
}
-bool DataSharingProcessor ::needBarrier() {
+bool DataSharingProcessor::needBarrier() {
for (const Fortran::semantics::Symbol *sym : privatizedSymbols) {
if (sym->test(Fortran::semantics::Symbol::Flag::OmpFirstPrivate) &&
sym->test(Fortran::semantics::Symbol::Flag::OmpLastPrivate))
@@ -299,7 +299,7 @@ bool DataSharingProcessor ::needBarrier() {
return false;
}
-void DataSharingProcessor ::insertBarrier() {
+void DataSharingProcessor::insertBarrier() {
// Emit implicit barrier to synchronize threads and avoid data races on
// initialization of firstprivate variables and post-update of lastprivate
// variables.
|
kiranchandramohan
approved these changes
Jan 16, 2024
justinfargnoli
pushed a commit
to justinfargnoli/llvm-project
that referenced
this pull request
Jan 28, 2024
llvm#78205) … NFC The names were ``` bool DataSharingProcessor ::needBarrier() void DataSharingProcessor ::insertBarrier() ``` It seems like clang-format treats those as references to the global namespace instead of separators in a qualified name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… NFC
The names were
It seems like clang-format treats those as references to the global namespace instead of separators in a qualified name.