[mlir][OpenMP] Remove unnecessary hard dialect dependencies #78220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes dialect dependencies from the OpenMP dialect; all external models were moved to independent libraries to accomplish this change. Consequently, OpenMP dialect users can pull only the desired external models; for example, a user might choose not to include OpenMP Func external models. However, all external models still reside inside the OpenMP dialect, as it's the owner of those interfaces. Additionally, an external model was included for the GPUModule operation.
fabianmcg
changed the title
fabianmcg
added a commit
to fabianmcg/llvm-project
that referenced
this pull request
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes dialect dependencies from the OpenMP dialect; all external models were moved to independent libraries to accomplish this change. Consequently, OpenMP dialect users can pull only the desired external models; for example, a user might choose not to include OpenMP Func external models. However, all external models still reside inside the OpenMP dialect, as it's the owner of those interfaces.
Additionally, an external model was included for the GPUModule operation.