Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Add lld as compiler-rt dependecy #78536

Merged
merged 5 commits into from
Jan 18, 2024
Merged

[CI] Add lld as compiler-rt dependecy #78536

merged 5 commits into from
Jan 18, 2024

Conversation

vitalybuka
Copy link
Collaborator

@vitalybuka vitalybuka commented Jan 18, 2024 •
edited

@MaskRay
Copy link
Member

MaskRay commented Jan 18, 2024 

+ /var/lib/buildkite-agent/builds/linux-56-59b8f5d88-tdgkv-1/llvm-project/github-pull-requests/build/./bin/clang -m64 -fuse-ld=lld -flto=thin -fsanitize=cfi -fwhole-program-vtables --driver-mode=g++ -fsanitize-cfi-cross-dso -fvisibility=default /var/lib/buildkite-agent/builds/linux-56-59b8f5d88-tdgkv-1/llvm-project/github-pull-requests/compiler-rt/test/cfi/cross-dso/icall/dlopen.cpp -o /var/lib/buildkite-agent/builds/linux-56-59b8f5d88-tdgkv-1/llvm-project/github-pull-requests/build/projects/compiler-rt/test/cfi/Devirt-lld-thinlto-x86_64/cross-dso/icall/Output/dlopen.cpp.tmp1
ld.lld: error: /tmp/lit-tmp-cr6hdctc/dlopen-e2fa9b.o: Unknown attribute kind (91) (Producer: 'LLVM18.0.0git' Reader: 'LLVM 16.0.6')
clang: error: linker command failed with exit code 1 (use -v to see invocation)

The failure looks like an old version of lld (system one?) is used.

XinWang10 and others added 2 commits January 17, 2024 21:06
@XinWang10 @vitalybuka
[𝘀𝗽𝗿] changes introduced through rebase
fff88f5 
Created using spr 1.3.4

[skip ci]
@vitalybuka
rebase
e0b5094 
Created using spr 1.3.4
@vitalybuka vitalybuka changed the base branch from users/vitalybuka/spr/main.ci-add-lld-as-compiler-rt-dependecy to main January 18, 2024 05:08
@vitalybuka
rebase
b13b120 
Created using spr 1.3.4
@vitalybuka vitalybuka merged commit f01b6ca into main Jan 18, 2024
3 of 4 checks passed
@vitalybuka vitalybuka deleted the users/vitalybuka/spr/ci-add-lld-as-compiler-rt-dependecy branch January 18, 2024 05:10
@vitalybuka
Copy link
Collaborator Author

@XinWang10 Sorry, you accidentally pulled in here by spr diff after rebase.

ampandey-1995 pushed a commit to ampandey-1995/llvm-project that referenced this pull request Jan 19, 2024
@vitalybuka @XinWang10 @ampandey-1995
[CI] Add lld as compiler-rt dependecy (llvm#78536)
192f430 
Fixing
https://buildkite.com/llvm-project/github-pull-requests/builds/30321#018d1a4a-bf72-449e-a70a-444ded875255

Co-authored-by: XinWang10 <108658776+XinWang10@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaskRay MaskRay MaskRay approved these changes

@ldionne ldionne Awaiting requested review from ldionne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vitalybuka @MaskRay @XinWang10