Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ArgPromotion] Handle pointer arguments of recursive calls #78735

Merged
merged 19 commits into from
Jul 12, 2024
Merged

[ArgPromotion] Handle pointer arguments of recursive calls #78735

merged 19 commits into from
Jul 12, 2024

Commits on Jul 11, 2024

  1. [ArgPromotion] Handle pointer arguments of recursive calls 

    Argument promotion doesn't handle recursive function calls to promote
arguments. This patch adds functionality to handle self recursive
function calls, i.e. whose SCC size is 1. Due to complexity of Value
Tracking in recursive calls with SCC size greater than 1, we bail out
in such cases.
    @vedantparanjape-amd
    vedantparanjape-amd committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    e00aa99 View commit details
    Browse the repository at this point in the history

  2. Add a check to stop recursive promotion of ptr args

    @vedantparanjape-amd
    vedantparanjape-amd committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    3f7d632 View commit details
    Browse the repository at this point in the history

  3. Address review comments

    @vedantparanjape-amd
    vedantparanjape-amd committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d3d6872 View commit details
    Browse the repository at this point in the history

  4. Address review 2 comments

    @vedantparanjape-amd
    vedantparanjape-amd committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    ba01424 View commit details
    Browse the repository at this point in the history

  5. minor nitpick

    @vedantparanjape-amd
    vedantparanjape-amd committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    a183702 View commit details
    Browse the repository at this point in the history

  6. Address review 3 comments

    @vedantparanjape-amd
    vedantparanjape-amd committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d5bbcf0 View commit details
    Browse the repository at this point in the history

  7. Address review 4 comments

    @vedantparanjape-amd
    vedantparanjape-amd committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    b7c4129 View commit details
    Browse the repository at this point in the history

  8. Refactor and add comments, also address review comments

    @vedantparanjape-amd
    vedantparanjape-amd committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    979dd21 View commit details
    Browse the repository at this point in the history

  9. Add check for self recursion

    @vedantparanjape-amd
    vedantparanjape-amd committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    4457b7a View commit details
    Browse the repository at this point in the history

  10. Add check if call is recursion

    @vedantparanjape-amd
    vedantparanjape-amd committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d9ca124 View commit details
    Browse the repository at this point in the history

  11. remove isSelfRecursive check

    @vedantparanjape-amd
    vedantparanjape-amd committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    169eee2 View commit details
    Browse the repository at this point in the history

  12. Add check for argument number as well in recursive calls

    @vedantparanjape-amd
    vedantparanjape-amd committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    9dc8504 View commit details
    Browse the repository at this point in the history

  13. Added more testcases

    @vedantparanjape-amd
    vedantparanjape-amd committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    fb7b1ad View commit details
    Browse the repository at this point in the history

  14. Add more tests, and move them to a folder

    @vedantparanjape-amd
    vedantparanjape-amd committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    42fa56e View commit details
    Browse the repository at this point in the history

  15. Added testcase for multiple elements

    @vedantparanjape-amd
    vedantparanjape-amd committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    78f9df5 View commit details
    Browse the repository at this point in the history

  16. Removed IsSelfRecursive from findArgParts

    @vedantparanjape-amd
    vedantparanjape-amd committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d0968a5 View commit details
    Browse the repository at this point in the history

  17. Use SmallPtrSetImpl in a helper function

    @vedantparanjape-amd
    vedantparanjape-amd committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    213c134 View commit details
    Browse the repository at this point in the history

  18. minor fix to SmallPtrSetImpl

    @vedantparanjape-amd
    vedantparanjape-amd committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    881c4cd View commit details
    Browse the repository at this point in the history

  19. Remove use of stripAndAccumulateConstantOffsets

    @vedantparanjape-amd
    vedantparanjape-amd committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    5a053f9 View commit details
    Browse the repository at this point in the history