Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[llvm-rc] Support ARM64EC resource generation #78908

Merged
merged 1 commit into from
Jan 31, 2024
Merged

[llvm-rc] Support ARM64EC resource generation #78908

merged 1 commit into from
Jan 31, 2024

Conversation

bylaws
Copy link
Contributor

@bylaws bylaws commented Jan 21, 2024

This is already supported in llvm-cvtres, so only a small change is needed.

CC: @cjacek

@mstorsjo
Copy link
Member

This looks good, but can we have a testcase?

@bylaws
Copy link
Contributor Author

bylaws commented Jan 31, 2024

This looks good, but can we have a testcase?

Done

mstorsjo
mstorsjo approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@mstorsjo mstorsjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test!

@mstorsjo mstorsjo merged commit d55d72e into llvm:main Jan 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstorsjo mstorsjo mstorsjo approved these changes

@dpaoliello dpaoliello dpaoliello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bylaws @mstorsjo @dpaoliello