[flang] Do not leak intrinsics used by ISO_C_BINDING and ISO_FORTRAN_ENV #79006
+62
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzurob
reviewed
Jan 22, 2024
| @@ -22,6 +22,12 @@ module iso_c_binding | |||
| c_sizeof => sizeof, & | |||
| operator(==), operator(/=) | |||
|
|
|||
| implicit none | |||
|
|
|||
There was a problem hiding this comment.
It might be better to add the private statement on line 26 so that everything is private by default and then add explicit public statements for the things you want to be public. This way, future additions don't leak by default.
There was a problem hiding this comment.
Good point! Even though it's way more to change, I like the suggestion as it's future proof. Please have a look at the new commit.
Please have another look. @rzurob Had a good suggestion to turn the logic around and make everything private by default. |
klausler
approved these changes
Jan 22, 2024
kparzysz
pushed a commit
that referenced
this pull request
Feb 19, 2024
…bols (#80833) This PR continues the work started with PR #79006, by setting visibility in MODULES to PRIVATE by default and explicitly exporting only the desired symbols. `omp_lib` needs more work, as it should maybe be compiled from `omp_lib.f90` in `openmp/runtime/src/incluce/omp_lib.f90.var` instead of simply using an INCLUDE for `omp_lib.h`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves bug #78953. Intrinsics used by the MODULE definition are being declared PRIVATE, so that they do not leak into the namespace of the code that USEs the modules.