Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test #79018

Merged
merged 1 commit into from
Jan 23, 2024
Merged

fix test #79018

merged 1 commit into from
Jan 23, 2024

Conversation

Un1q32
Copy link
Contributor

@Un1q32 Un1q32 commented Jan 22, 2024

Mistake with #78628 that got caught after being merged

@llvmbot
Copy link
Collaborator

llvmbot commented Jan 22, 2024

@llvm/pr-subscribers-lld-macho

@llvm/pr-subscribers-lld

Author: None (OldWorldOrdr)

Changes

Mistake with #78628 that got caught after being merged


Full diff: https://github.com/llvm/llvm-project/pull/79018.diff

1 Files Affected:

  • (modified) lld/test/MachO/link-csu-object.s (+1-1)
diff --git a/lld/test/MachO/link-csu-object.s b/lld/test/MachO/link-csu-object.s
index e6f5ff7e52e325..a36e50a8901bd0 100644
--- a/lld/test/MachO/link-csu-object.s
+++ b/lld/test/MachO/link-csu-object.s
@@ -2,7 +2,7 @@
 # RUN: mkdir -p %t
 # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %p/Inputs/libhello.s -o %t/hello.o
 # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %s -o %t/main.o
-# RUN: %lld -L %t %t/main.o %t/hello.o -o %t/a.out
+# RUN: %lld -L %t %t/main.o -lhello.o -o %t/a.out
 # RUN: llvm-nm %t/a.out | FileCheck %s
 
 # CHECK: _main

@oontvoo
Copy link
Member

oontvoo commented Jan 22, 2024

(Will merge after the pending checks finish)

Copy link
Collaborator

@smeenai smeenai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@oontvoo oontvoo merged commit 654131f into llvm:main Jan 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants