Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMDGPU][NFC] Remove FIXME that has been resolved #79047

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

AtariDreams
Copy link
Contributor

As of 5aea839, this FIXME has been resolved.

So we can remove this comment.

@llvmbot
Copy link
Collaborator

llvmbot commented Jan 22, 2024

@llvm/pr-subscribers-backend-amdgpu

Author: AtariDreams (AtariDreams)

Changes

As of 5aea839, this FIXME has been resolved.

So we can remove this comment.


Full diff: https://github.com/llvm/llvm-project/pull/79047.diff

1 Files Affected:

  • (modified) llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp (-1)
diff --git a/llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp b/llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp
index a2cacb5cbaa393a..8f9d95c6d4b1421 100644
--- a/llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp
+++ b/llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp
@@ -1619,7 +1619,6 @@ void SIRegisterInfo::buildSpillLoadStore(
       }
       SubReg = TmpIntermediateVGPR;
     } else if (UseVGPROffset) {
-      // FIXME: change to scavengeRegisterBackwards()
       if (!TmpOffsetVGPR) {
         TmpOffsetVGPR = RS->scavengeRegisterBackwards(AMDGPU::VGPR_32RegClass,
                                                       MI, false, 0);

Copy link
Contributor

@jayfoad jayfoad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@arsenm arsenm changed the title [ANDGPU][NFC] Remove FIXME that has been resolved [AMDGPU][NFC] Remove FIXME that has been resolved Jan 23, 2024
@AtariDreams
Copy link
Contributor Author

@arsenm Can we merge this?

As of 5aea839, this FIXME has been resolved.

So we can remove this comment.
@arsenm arsenm merged commit af91b42 into llvm:main Jan 26, 2024
3 of 4 checks passed
@AtariDreams AtariDreams deleted the scavenge branch January 26, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants