[NVPTX] use incomplete aggregate initializers #79062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Artem-B, could you please review this MR when you have a chance? |
Artem-B
reviewed
Jan 22, 2024
AlexMaclean
force-pushed
the
upstream/incomplete-init
branch
from
2b067e2
to
d3c4019
Compare
|
@Artem-B, I've addressed all comments, please let me know if there is anything else I should do to fix this up, if not please land on my behalf once tests pass. |
Artem-B
reviewed
Jan 23, 2024
|
@Artem-B, could you please land this om my behalf? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PTX ISA specifies that initializers may be incomplete (5.4.4. Initializers)
Emitting initializers in this form is preferable because it reduces the size of the PTX, in some cases significantly, and can improve compile time of ptxas as a result.