Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[clang-repl] Enable native CPU detection by default (#77491)" #79178

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

weliveindetail
Copy link
Contributor

Reverting because clang-repl -Xcc -mcpu=arm1176jzf-s isn't overwriting this as I had expected. We need to check whether a specific CPU flag was given by the user first.

Reverts #77491

@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Jan 23, 2024
@weliveindetail weliveindetail merged commit 6a7abea into main Jan 23, 2024
5 of 6 checks passed
@weliveindetail weliveindetail deleted the revert-77491-clang-repl-mcpu-native branch January 23, 2024 17:44
@llvmbot
Copy link
Collaborator

llvmbot commented Jan 23, 2024

@llvm/pr-subscribers-clang

Author: Stefan Gränitz (weliveindetail)

Changes

Reverting because clang-repl -Xcc -mcpu=arm1176jzf-s isn't overwriting this as I had expected. We need to check whether a specific CPU flag was given by the user first.

Reverts llvm/llvm-project#77491


Full diff: https://github.com/llvm/llvm-project/pull/79178.diff

1 Files Affected:

  • (modified) clang/lib/Interpreter/Interpreter.cpp (-1)
diff --git a/clang/lib/Interpreter/Interpreter.cpp b/clang/lib/Interpreter/Interpreter.cpp
index d1764d07dfd2407..9f97a3c6b0be9e6 100644
--- a/clang/lib/Interpreter/Interpreter.cpp
+++ b/clang/lib/Interpreter/Interpreter.cpp
@@ -148,7 +148,6 @@ IncrementalCompilerBuilder::create(std::vector<const char *> &ClangArgv) {
   // We do C++ by default; append right after argv[0] if no "-x" given
   ClangArgv.insert(ClangArgv.end(), "-Xclang");
   ClangArgv.insert(ClangArgv.end(), "-fincremental-extensions");
-  ClangArgv.insert(ClangArgv.end(), "-mcpu=native");
   ClangArgv.insert(ClangArgv.end(), "-c");
 
   // Put a dummy C++ file on to ensure there's at least one compile job for the

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants