Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Mention RISC-V in the introductory paragraph in ShadowCallStack.rst. #79241

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

topperc
Copy link
Collaborator

@topperc topperc commented Jan 24, 2024

RISC-V is mentioned elsewhere in the document it seems like it should be mentioned in the introduction.

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Jan 24, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Jan 24, 2024

@llvm/pr-subscribers-clang

Author: Craig Topper (topperc)

Changes

RISC-V is mentioned elsewhere in the document it seems like it should be mentioned in the introduction.


Full diff: https://github.com/llvm/llvm-project/pull/79241.diff

1 Files Affected:

  • (modified) clang/docs/ShadowCallStack.rst (+1-1)
diff --git a/clang/docs/ShadowCallStack.rst b/clang/docs/ShadowCallStack.rst
index 04c04d259d7dc6f..6e5192fd672391b 100644
--- a/clang/docs/ShadowCallStack.rst
+++ b/clang/docs/ShadowCallStack.rst
@@ -9,7 +9,7 @@ Introduction
 ============
 
 ShadowCallStack is an instrumentation pass, currently only implemented for
-aarch64, that protects programs against return address overwrites
+aarch64 and RISC-V, that protects programs against return address overwrites
 (e.g. stack buffer overflows.) It works by saving a function's return address
 to a separately allocated 'shadow call stack' in the function prolog in
 non-leaf functions and loading the return address from the shadow call stack

Copy link
Contributor

@ilovepi ilovepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@topperc topperc merged commit e6f576b into llvm:main Jan 24, 2024
5 of 6 checks passed
@topperc topperc deleted the pr/shadowstack-docs branch January 24, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants