Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[polly][ScheduleOptimizer] Use IslMaxOperationsGuard helper instead of explicit restoration #79303

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

kartcq
Copy link
Contributor

@kartcq kartcq commented Jan 24, 2024

To fix long compile time issue of Schedule optimizer, patch #77280 sets the upper cap on max ISL operations. In case of bailing out when ISL quota is hit, error handling behavior was restored manually. This commit replaces the restoration code with IslMaxOperationsGuard helper and also removes redundant early return.

…f explicit restoration

To fix long compile time issue of Schedule optimizer, patch llvm#77280 sets
the upper cap on max ISL operations. In case of bailing out when isl
quota is hit, error handling behavior was restored manually. This
commit replaces the restoration code with IslMaxOperationsGuard helper
and also removes redundant early return.
…f explicit restoration

To fix long compile time issue of Schedule optimizer, patch llvm#77280 sets
the upper cap on max ISL operations. In case of bailing out when isl
quota is hit, error handling behavior was restored manually. This
commit replaces the restoration code with IslMaxOperationsGuard helper
and also removes redundant early return. This way of using helper is
less error-prone as well.
Copy link
Collaborator

@efriedma-quic efriedma-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efriedma-quic efriedma-quic merged commit 0f33c54 into llvm:main Feb 14, 2024
4 checks passed
@kartcq kartcq deleted the bug_fix_2 branch February 28, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants