Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOLT] Report input staleness #79496

Merged
merged 3 commits into from
Jan 25, 2024
Merged

[BOLT] Report input staleness #79496

merged 3 commits into from
Jan 25, 2024

Conversation

aaupov
Copy link
Contributor

@aaupov aaupov commented Jan 25, 2024

It's beneficial to have uniform reporting in both infer-stale-profile
on and off cases, primarily for logging purposes.

Without this change, BOLT would report "input" staleness in
infer-stale-profile=0 case (without matching), and "output" staleness
in infer-stale-profile=1 case (after matching).

This change makes BOLT report "input" staleness in both cases. "Output"
staleness information is printed separately with "BOLT-INFO: inferred
profile..."

@maksfb
Copy link
Contributor

maksfb commented Jan 25, 2024

Can you add a test case?

Copy link
Contributor

@maksfb maksfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@aaupov aaupov merged commit e9309b2 into llvm:main Jan 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants