[workflows] Use a custom token for creating backport PRs #79501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CI tests don't get triggered if a PR is created by the builtin github token, so we need to use a custom token when creating a PR.
|
@llvm/pr-subscribers-github-workflow Author: Tom Stellard (tstellar) ChangesThe CI tests don't get triggered if a PR is created by the builtin github token, so we need to use a custom token when creating a PR. Full diff: https://github.com/llvm/llvm-project/pull/79501.diff 1 Files Affected:
diff --git a/.github/workflows/issue-release-workflow.yml b/.github/workflows/issue-release-workflow.yml
index 112ece40bac9c1a..33a1e89a729f6b1 100644
--- a/.github/workflows/issue-release-workflow.yml
+++ b/.github/workflows/issue-release-workflow.yml
@@ -61,7 +61,7 @@ jobs:
printf "%s" "$COMMENT_BODY" |
./llvm/utils/git/github-automation.py \
--repo "$GITHUB_REPOSITORY" \
- --token ${{ github.token }} \
+ --token "${{ secrets.RELEASE_WORKFLOW_PR_CREATE }}" \
release-workflow \
--branch-repo-token ${{ secrets.RELEASE_WORKFLOW_PUSH_SECRET }} \
--issue-number ${{ github.event.issue.number }} \
|
nikic
reviewed
Jan 26, 2024
| @@ -61,7 +61,7 @@ jobs: | |||
| printf "%s" "$COMMENT_BODY" | | |||
| ./llvm/utils/git/github-automation.py \ | |||
| --repo "$GITHUB_REPOSITORY" \ | |||
| --token ${{ github.token }} \ | |||
| --token "${{ secrets.RELEASE_WORKFLOW_PR_CREATE }}" \ | |||
There was a problem hiding this comment.
Just to double check, does this token also have permission to create issue comments? It will be used for that as well.
There was a problem hiding this comment.
I just added issue permissions to the token.
nikic
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI tests don't get triggered if a PR is created by the builtin github token, so we need to use a custom token when creating a PR.