Restore lost nuance in DeveloperPolicy regarding input languages for test cases #79527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cases While re-reading the various policies for changes I've missed, I noticed that the policy on test cases had been rewritten to be a bit overly restrictive and not accurately reflect the test cases in LLVM today. Back in 2019 (git: e0ddc73, svn: 201619), some references to llvm-gcc were removed from the DeveloperPolicy. One of these removals removed some important nuance along with the example that referenced llvm-gcc. The original text was: > * Test cases should be written in `LLVM assembly language <LangRef.html>`_ > unless the feature or regression being tested requires another language > (e.g. the bug being fixed or feature being implemented is in the llvm-gcc > C++ front-end, in which case it must be written in C++). and this was reduced to: > * Test cases should be written in :doc:`LLVM assembly language <LangRef>`. which is a bit too definite and restrictive. This commit attempts to restore the original intent but with examples that exist in the current LLVM source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While re-reading the various policies for changes I've missed, I noticed that the policy on test cases had been rewritten to be a bit overly restrictive and not accurately reflect the test cases in LLVM today.
Back in 2019 (git: e0ddc73, svn: 201619), some references to llvm-gcc were removed from the DeveloperPolicy. One of these removals removed some important nuance along with the example that referenced llvm-gcc. The original text was:
and this was reduced to:
which is a bit too definite and restrictive.
This commit attempts to restore the original intent but with examples that exist in the current LLVM source.