[TextAPI] Rename SymbolKind to EncodeKind #79622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A distinction that doesn't _usually_ matter is that the MachO::SymbolKind is really a mapping of entries in TBD files not symbols. To better understand this, rename the enum so it represents an encoding mapped to TBDs as opposed to symbols alone. For example, it can be a bit confusing that "GlobalSymbol" is a enum value when all of those values can represent a GlobalSymbol.
|
@llvm/pr-subscribers-lld-macho @llvm/pr-subscribers-llvm-binary-utilities Author: Cyndy Ishida (cyndyishida) ChangesA distinction that doesn't usually matter is that the MachO::SymbolKind is really a mapping of entries in TBD files not symbols. To better understand this, rename the enum so it represents an encoding mapped to TBDs as opposed to symbols alone. For example, it can be a bit confusing that "GlobalSymbol" is a enum value when all of those values can represent a GlobalSymbol. Patch is 67.95 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/79622.diff 19 Files Affected:
diff --git a/llvm/include/llvm/TextAPI/InterfaceFile.h b/llvm/include/llvm/TextAPI/InterfaceFile.h
index 1b21a7bbeeee1bc..3b63f6187769529 100644
--- a/llvm/include/llvm/TextAPI/InterfaceFile.h
+++ b/llvm/include/llvm/TextAPI/InterfaceFile.h
@@ -351,7 +351,7 @@ class InterfaceFile {
///
/// \param Kind The kind of global symbol to record.
/// \param Name The name of the symbol.
- std::optional<const Symbol *> getSymbol(SymbolKind Kind,
+ std::optional<const Symbol *> getSymbol(EncodeKind Kind,
StringRef Name) const {
if (auto *Sym = SymbolsSet->findSymbol(Kind, Name))
return Sym;
@@ -361,7 +361,7 @@ class InterfaceFile {
/// Add a symbol to the symbols list or extend an existing one.
template <typename RangeT, typename ElT = std::remove_reference_t<
decltype(*std::begin(std::declval<RangeT>()))>>
- void addSymbol(SymbolKind Kind, StringRef Name, RangeT &&Targets,
+ void addSymbol(EncodeKind Kind, StringRef Name, RangeT &&Targets,
SymbolFlags Flags = SymbolFlags::None) {
SymbolsSet->addGlobal(Kind, Name, Flags, Targets);
}
@@ -372,7 +372,7 @@ class InterfaceFile {
/// \param Name The name of the symbol.
/// \param Targets The list of targets the symbol is defined in.
/// \param Flags The properties the symbol holds.
- void addSymbol(SymbolKind Kind, StringRef Name, TargetList &&Targets,
+ void addSymbol(EncodeKind Kind, StringRef Name, TargetList &&Targets,
SymbolFlags Flags = SymbolFlags::None) {
SymbolsSet->addGlobal(Kind, Name, Flags, Targets);
}
@@ -383,7 +383,7 @@ class InterfaceFile {
/// \param Name The name of the symbol.
/// \param Target The target the symbol is defined in.
/// \param Flags The properties the symbol holds.
- void addSymbol(SymbolKind Kind, StringRef Name, Target &Target,
+ void addSymbol(EncodeKind Kind, StringRef Name, Target &Target,
SymbolFlags Flags = SymbolFlags::None) {
SymbolsSet->addGlobal(Kind, Name, Flags, Target);
}
diff --git a/llvm/include/llvm/TextAPI/Symbol.h b/llvm/include/llvm/TextAPI/Symbol.h
index fc7f600b2e02002..37a149a39489f1a 100644
--- a/llvm/include/llvm/TextAPI/Symbol.h
+++ b/llvm/include/llvm/TextAPI/Symbol.h
@@ -51,7 +51,8 @@ enum class SymbolFlags : uint8_t {
// clang-format on
-enum class SymbolKind : uint8_t {
+/// Mapping of entry types in TextStubs.
+enum class EncodeKind : uint8_t {
GlobalSymbol,
ObjectiveCClass,
ObjectiveCClassEHType,
@@ -81,11 +82,11 @@ typename C::iterator addEntry(C &Container, const Target &Targ) {
class Symbol {
public:
- Symbol(SymbolKind Kind, StringRef Name, TargetList Targets, SymbolFlags Flags)
+ Symbol(EncodeKind Kind, StringRef Name, TargetList Targets, SymbolFlags Flags)
: Name(Name), Targets(std::move(Targets)), Kind(Kind), Flags(Flags) {}
void addTarget(Target InputTarget) { addEntry(Targets, InputTarget); }
- SymbolKind getKind() const { return Kind; }
+ EncodeKind getKind() const { return Kind; }
StringRef getName() const { return Name; }
ArchitectureSet getArchitectures() const {
return mapToArchitectureSet(Targets);
@@ -156,21 +157,21 @@ class Symbol {
private:
StringRef Name;
TargetList Targets;
- SymbolKind Kind;
+ EncodeKind Kind;
SymbolFlags Flags;
};
/// Lightweight struct for passing around symbol information.
struct SimpleSymbol {
StringRef Name;
- SymbolKind Kind;
+ EncodeKind Kind;
bool operator<(const SimpleSymbol &O) const {
return std::tie(Name, Kind) < std::tie(O.Name, O.Kind);
}
};
-/// Determine SymbolKind from Flags and parsing Name.
+/// Determine EncodeKind from Flags and parsing Name.
///
/// \param Name The name of symbol.
/// \param Flags The flags pre-determined for the symbol.
diff --git a/llvm/include/llvm/TextAPI/SymbolSet.h b/llvm/include/llvm/TextAPI/SymbolSet.h
index 5b67ebea11ed086..966347f0feaa1c4 100644
--- a/llvm/include/llvm/TextAPI/SymbolSet.h
+++ b/llvm/include/llvm/TextAPI/SymbolSet.h
@@ -23,19 +23,19 @@
namespace llvm {
struct SymbolsMapKey {
- MachO::SymbolKind Kind;
+ MachO::EncodeKind Kind;
StringRef Name;
- SymbolsMapKey(MachO::SymbolKind Kind, StringRef Name)
+ SymbolsMapKey(MachO::EncodeKind Kind, StringRef Name)
: Kind(Kind), Name(Name) {}
};
template <> struct DenseMapInfo<SymbolsMapKey> {
static inline SymbolsMapKey getEmptyKey() {
- return SymbolsMapKey(MachO::SymbolKind::GlobalSymbol, StringRef{});
+ return SymbolsMapKey(MachO::EncodeKind::GlobalSymbol, StringRef{});
}
static inline SymbolsMapKey getTombstoneKey() {
- return SymbolsMapKey(MachO::SymbolKind::ObjectiveCInstanceVariable,
+ return SymbolsMapKey(MachO::EncodeKind::ObjectiveCInstanceVariable,
StringRef{});
}
@@ -87,27 +87,27 @@ class SymbolSet {
using SymbolsMapType = llvm::DenseMap<SymbolsMapKey, Symbol *>;
SymbolsMapType Symbols;
- Symbol *addGlobalImpl(SymbolKind, StringRef Name, SymbolFlags Flags);
+ Symbol *addGlobalImpl(EncodeKind, StringRef Name, SymbolFlags Flags);
public:
SymbolSet() = default;
- Symbol *addGlobal(SymbolKind Kind, StringRef Name, SymbolFlags Flags,
+ Symbol *addGlobal(EncodeKind Kind, StringRef Name, SymbolFlags Flags,
const Target &Targ);
size_t size() const { return Symbols.size(); }
template <typename RangeT, typename ElT = std::remove_reference_t<
decltype(*std::begin(std::declval<RangeT>()))>>
- Symbol *addGlobal(SymbolKind Kind, StringRef Name, SymbolFlags Flags,
+ Symbol *addGlobal(EncodeKind Kind, StringRef Name, SymbolFlags Flags,
RangeT &&Targets) {
auto *Global = addGlobalImpl(Kind, Name, Flags);
for (const auto &Targ : Targets)
Global->addTarget(Targ);
- if (Kind == SymbolKind::ObjectiveCClassEHType)
- addGlobal(SymbolKind::ObjectiveCClass, Name, Flags, Targets);
+ if (Kind == EncodeKind::ObjectiveCClassEHType)
+ addGlobal(EncodeKind::ObjectiveCClass, Name, Flags, Targets);
return Global;
}
- const Symbol *findSymbol(SymbolKind Kind, StringRef Name) const;
+ const Symbol *findSymbol(EncodeKind Kind, StringRef Name) const;
struct const_symbol_iterator
: public iterator_adaptor_base<
diff --git a/llvm/lib/Object/TapiFile.cpp b/llvm/lib/Object/TapiFile.cpp
index fcf61541941ea3e..4eaacc48e7ce048 100644
--- a/llvm/lib/Object/TapiFile.cpp
+++ b/llvm/lib/Object/TapiFile.cpp
@@ -56,11 +56,11 @@ TapiFile::TapiFile(MemoryBufferRef Source, const InterfaceFile &Interface,
continue;
switch (Symbol->getKind()) {
- case SymbolKind::GlobalSymbol:
+ case EncodeKind::GlobalSymbol:
Symbols.emplace_back(StringRef(), Symbol->getName(), getFlags(Symbol),
::getType(Symbol));
break;
- case SymbolKind::ObjectiveCClass:
+ case EncodeKind::ObjectiveCClass:
if (Interface.getPlatforms().count(PLATFORM_MACOS) && Arch == AK_i386) {
Symbols.emplace_back(ObjC1ClassNamePrefix, Symbol->getName(),
getFlags(Symbol), ::getType(Symbol));
@@ -71,11 +71,11 @@ TapiFile::TapiFile(MemoryBufferRef Source, const InterfaceFile &Interface,
getFlags(Symbol), ::getType(Symbol));
}
break;
- case SymbolKind::ObjectiveCClassEHType:
+ case EncodeKind::ObjectiveCClassEHType:
Symbols.emplace_back(ObjC2EHTypePrefix, Symbol->getName(),
getFlags(Symbol), ::getType(Symbol));
break;
- case SymbolKind::ObjectiveCInstanceVariable:
+ case EncodeKind::ObjectiveCInstanceVariable:
Symbols.emplace_back(ObjC2IVarPrefix, Symbol->getName(), getFlags(Symbol),
::getType(Symbol));
break;
diff --git a/llvm/lib/TextAPI/RecordVisitor.cpp b/llvm/lib/TextAPI/RecordVisitor.cpp
index cee04e6447555b0..b049c9e579c3d14 100644
--- a/llvm/lib/TextAPI/RecordVisitor.cpp
+++ b/llvm/lib/TextAPI/RecordVisitor.cpp
@@ -41,17 +41,17 @@ void SymbolConverter::addIVars(const ArrayRef<ObjCIVarRecord *> IVars,
continue;
std::string Name =
ObjCIVarRecord::createScopedName(ContainerName, IV->getName());
- Symbols->addGlobal(SymbolKind::ObjectiveCInstanceVariable, Name,
+ Symbols->addGlobal(EncodeKind::ObjectiveCInstanceVariable, Name,
IV->getFlags(), Targ);
}
}
void SymbolConverter::visitObjCInterface(const ObjCInterfaceRecord &ObjCR) {
if (!shouldSkipRecord(ObjCR, RecordUndefs)) {
- Symbols->addGlobal(SymbolKind::ObjectiveCClass, ObjCR.getName(),
+ Symbols->addGlobal(EncodeKind::ObjectiveCClass, ObjCR.getName(),
ObjCR.getFlags(), Targ);
if (ObjCR.hasExceptionAttribute())
- Symbols->addGlobal(SymbolKind::ObjectiveCClassEHType, ObjCR.getName(),
+ Symbols->addGlobal(EncodeKind::ObjectiveCClassEHType, ObjCR.getName(),
ObjCR.getFlags(), Targ);
}
diff --git a/llvm/lib/TextAPI/RecordsSlice.cpp b/llvm/lib/TextAPI/RecordsSlice.cpp
index 840fe1855da6a6c..7f6fad17059943c 100644
--- a/llvm/lib/TextAPI/RecordsSlice.cpp
+++ b/llvm/lib/TextAPI/RecordsSlice.cpp
@@ -25,13 +25,13 @@ Record *RecordsSlice::addRecord(StringRef Name, SymbolFlags Flags,
auto [APIName, SymKind] = parseSymbol(Name, Flags);
Name = APIName;
switch (SymKind) {
- case SymbolKind::GlobalSymbol:
+ case EncodeKind::GlobalSymbol:
return addGlobal(Name, Linkage, GV, Flags);
- case SymbolKind::ObjectiveCClass:
+ case EncodeKind::ObjectiveCClass:
return addObjCInterface(Name, Linkage);
- case SymbolKind::ObjectiveCClassEHType:
+ case EncodeKind::ObjectiveCClassEHType:
return addObjCInterface(Name, Linkage, /*HasEHType=*/true);
- case SymbolKind::ObjectiveCInstanceVariable: {
+ case EncodeKind::ObjectiveCInstanceVariable: {
auto [Super, IVar] = Name.split('.');
// Attempt to find super class.
ObjCContainerRecord *Container = findContainer(/*isIVar=*/false, Super);
diff --git a/llvm/lib/TextAPI/Symbol.cpp b/llvm/lib/TextAPI/Symbol.cpp
index fd395436051d354..e67627e139831f1 100644
--- a/llvm/lib/TextAPI/Symbol.cpp
+++ b/llvm/lib/TextAPI/Symbol.cpp
@@ -28,16 +28,16 @@ LLVM_DUMP_METHOD void Symbol::dump(raw_ostream &OS) const {
if (isThreadLocalValue())
Result += "(tlv) ";
switch (Kind) {
- case SymbolKind::GlobalSymbol:
+ case EncodeKind::GlobalSymbol:
Result += Name.str();
break;
- case SymbolKind::ObjectiveCClass:
+ case EncodeKind::ObjectiveCClass:
Result += "(ObjC Class) " + Name.str();
break;
- case SymbolKind::ObjectiveCClassEHType:
+ case EncodeKind::ObjectiveCClassEHType:
Result += "(ObjC Class EH) " + Name.str();
break;
- case SymbolKind::ObjectiveCInstanceVariable:
+ case EncodeKind::ObjectiveCInstanceVariable:
Result += "(ObjC IVar) " + Name.str();
break;
}
@@ -75,27 +75,27 @@ bool Symbol::operator==(const Symbol &O) const {
SimpleSymbol parseSymbol(StringRef SymName, const SymbolFlags Flags) {
if (SymName.starts_with(ObjC1ClassNamePrefix))
return {SymName.drop_front(ObjC1ClassNamePrefix.size()),
- SymbolKind::ObjectiveCClass};
+ EncodeKind::ObjectiveCClass};
if (SymName.starts_with(ObjC2ClassNamePrefix))
return {SymName.drop_front(ObjC2ClassNamePrefix.size()),
- SymbolKind::ObjectiveCClass};
+ EncodeKind::ObjectiveCClass};
if (SymName.starts_with(ObjC2MetaClassNamePrefix))
return {SymName.drop_front(ObjC2MetaClassNamePrefix.size()),
- SymbolKind::ObjectiveCClass};
+ EncodeKind::ObjectiveCClass};
if (SymName.starts_with(ObjC2EHTypePrefix)) {
// When classes without ehtype are used in try/catch blocks
// a weak-defined symbol is exported. In those cases, treat these as a
// global instead.
if ((Flags & SymbolFlags::WeakDefined) == SymbolFlags::WeakDefined)
- return {SymName, SymbolKind::GlobalSymbol};
+ return {SymName, EncodeKind::GlobalSymbol};
return {SymName.drop_front(ObjC2EHTypePrefix.size()),
- SymbolKind::ObjectiveCClassEHType};
+ EncodeKind::ObjectiveCClassEHType};
}
if (SymName.starts_with(ObjC2IVarPrefix))
return {SymName.drop_front(ObjC2IVarPrefix.size()),
- SymbolKind::ObjectiveCInstanceVariable};
- return {SymName, SymbolKind::GlobalSymbol};
+ EncodeKind::ObjectiveCInstanceVariable};
+ return {SymName, EncodeKind::GlobalSymbol};
}
} // end namespace MachO.
diff --git a/llvm/lib/TextAPI/SymbolSet.cpp b/llvm/lib/TextAPI/SymbolSet.cpp
index 5b9882dadcdf40c..0cbfa2f6bc2d6d3 100644
--- a/llvm/lib/TextAPI/SymbolSet.cpp
+++ b/llvm/lib/TextAPI/SymbolSet.cpp
@@ -11,7 +11,7 @@
using namespace llvm;
using namespace llvm::MachO;
-Symbol *SymbolSet::addGlobalImpl(SymbolKind Kind, StringRef Name,
+Symbol *SymbolSet::addGlobalImpl(EncodeKind Kind, StringRef Name,
SymbolFlags Flags) {
Name = copyString(Name);
auto Result = Symbols.try_emplace(SymbolsMapKey{Kind, Name}, nullptr);
@@ -21,13 +21,13 @@ Symbol *SymbolSet::addGlobalImpl(SymbolKind Kind, StringRef Name,
return Result.first->second;
}
-Symbol *SymbolSet::addGlobal(SymbolKind Kind, StringRef Name, SymbolFlags Flags,
+Symbol *SymbolSet::addGlobal(EncodeKind Kind, StringRef Name, SymbolFlags Flags,
const Target &Targ) {
auto *Sym = addGlobalImpl(Kind, Name, Flags);
Sym->addTarget(Targ);
return Sym;
}
-const Symbol *SymbolSet::findSymbol(SymbolKind Kind, StringRef Name) const {
+const Symbol *SymbolSet::findSymbol(EncodeKind Kind, StringRef Name) const {
return Symbols.lookup({Kind, Name});
}
diff --git a/llvm/lib/TextAPI/TextStub.cpp b/llvm/lib/TextAPI/TextStub.cpp
index 9fa1459e95570a4..24a52607a981ca6 100644
--- a/llvm/lib/TextAPI/TextStub.cpp
+++ b/llvm/lib/TextAPI/TextStub.cpp
@@ -451,7 +451,7 @@ template <> struct MappingTraits<const InterfaceFile *> {
const auto *Symbol = SymArch.first;
switch (Symbol->getKind()) {
- case SymbolKind::GlobalSymbol:
+ case EncodeKind::GlobalSymbol:
if (Symbol->isWeakDefined())
Section.WeakDefSymbols.emplace_back(Symbol->getName());
else if (Symbol->isThreadLocalValue())
@@ -459,21 +459,21 @@ template <> struct MappingTraits<const InterfaceFile *> {
else
Section.Symbols.emplace_back(Symbol->getName());
break;
- case SymbolKind::ObjectiveCClass:
+ case EncodeKind::ObjectiveCClass:
if (File->getFileType() != FileType::TBD_V3)
Section.Classes.emplace_back(
copyString("_" + Symbol->getName().str()));
else
Section.Classes.emplace_back(Symbol->getName());
break;
- case SymbolKind::ObjectiveCClassEHType:
+ case EncodeKind::ObjectiveCClassEHType:
if (File->getFileType() != FileType::TBD_V3)
Section.Symbols.emplace_back(
copyString("_OBJC_EHTYPE_$_" + Symbol->getName().str()));
else
Section.ClassEHs.emplace_back(Symbol->getName());
break;
- case SymbolKind::ObjectiveCInstanceVariable:
+ case EncodeKind::ObjectiveCInstanceVariable:
if (File->getFileType() != FileType::TBD_V3)
Section.IVars.emplace_back(
copyString("_" + Symbol->getName().str()));
@@ -510,27 +510,27 @@ template <> struct MappingTraits<const InterfaceFile *> {
const auto *Symbol = SymArch.first;
switch (Symbol->getKind()) {
- case SymbolKind::GlobalSymbol:
+ case EncodeKind::GlobalSymbol:
if (Symbol->isWeakReferenced())
Section.WeakRefSymbols.emplace_back(Symbol->getName());
else
Section.Symbols.emplace_back(Symbol->getName());
break;
- case SymbolKind::ObjectiveCClass:
+ case EncodeKind::ObjectiveCClass:
if (File->getFileType() != FileType::TBD_V3)
Section.Classes.emplace_back(
copyString("_" + Symbol->getName().str()));
else
Section.Classes.emplace_back(Symbol->getName());
break;
- case SymbolKind::ObjectiveCClassEHType:
+ case EncodeKind::ObjectiveCClassEHType:
if (File->getFileType() != FileType::TBD_V3)
Section.Symbols.emplace_back(
copyString("_OBJC_EHTYPE_$_" + Symbol->getName().str()));
else
Section.ClassEHs.emplace_back(Symbol->getName());
break;
- case SymbolKind::ObjectiveCInstanceVariable:
+ case EncodeKind::ObjectiveCInstanceVariable:
if (File->getFileType() != FileType::TBD_V3)
Section.IVars.emplace_back(
copyString("_" + Symbol->getName().str()));
@@ -615,32 +615,32 @@ template <> struct MappingTraits<const InterfaceFile *> {
for (const auto &Symbol : Section.Symbols) {
if (Ctx->FileKind != FileType::TBD_V3 &&
Symbol.value.starts_with(ObjC2EHTypePrefix))
- File->addSymbol(SymbolKind::ObjectiveCClassEHType,
+ File->addSymbol(EncodeKind::ObjectiveCClassEHType,
Symbol.value.drop_front(15), Targets, Flags);
else
- File->addSymbol(SymbolKind::GlobalSymbol, Symbol, Targets, Flags);
+ File->addSymbol(EncodeKind::GlobalSymbol, Symbol, Targets, Flags);
}
for (auto &Symbol : Section.Classes) {
auto Name = Symbol.value;
if (Ctx->FileKind != FileType::TBD_V3)
Name = Name.drop_front();
- File->addSymbol(SymbolKind::ObjectiveCClass, Name, Targets, Flags);
+ File->addSymbol(EncodeKind::ObjectiveCClass, Name, Targets, Flags);
}
for (auto &Symbol : Section.ClassEHs)
- File->addSymbol(SymbolKind::ObjectiveCClassEHType, Symbol, Targets,
+ File->addSymbol(EncodeKind::ObjectiveCClassEHType, Symbol, Targets,
Flags);
for (auto &Symbol : Section.IVars) {
auto Name = Symbol.value;
if (Ctx->FileKind != FileType::TBD_V3)
Name = Name.drop_front();
- File->addSymbol(SymbolKind::ObjectiveCInstanceVariable, Name, Targets,
+ File->addSymbol(EncodeKind::ObjectiveCInstanceVariable, Name, Targets,
Flags);
}
for (auto &Symbol : Section.WeakDefSymbols)
- File->addSymbol(SymbolKind::GlobalSymbol, Symbol, Targets,
+ File->addSymbol(EncodeKind::GlobalSymbol, Symbol, Targets,
SymbolFlags::WeakDefined | Flags);
for (auto &Symbol : Section.TLVSymbols)
- File->addSymbol(SymbolKind::GlobalSymbol, Symbol, Targets,
+ File->addSymbol(EncodeKind::GlobalSymbol, Symbol, Targets,
SymbolFlags::ThreadLocalValue | Flags);
}
@@ -650,32 +650,32 @@ template <> struct MappingTraits<const InterfaceFile *> {
for (auto &Symbol : Section.Symbols) {
if (Ctx->FileKind != FileType::TBD_V3 &&
Symbol.value.starts_with(ObjC2EHTypePrefix))
- File->addSymbol(SymbolKind::ObjectiveCClassEHType,
+ File->addSymbol(EncodeKind::ObjectiveCClassEHType,
Symbol.value.drop_front(15), Targets,
SymbolFlags::Undefined | Flags);
else
- File->addSymbol(SymbolKind::GlobalSymbol, Symbol, Targets,
+ File->addSymbol(EncodeKind::GlobalSymbol, Symbol, Targets,
SymbolFlags::Undefined | Flags);
}
for (auto &Symbol : Section.Classes) {
auto Name = Symbol.value;
if (Ctx->FileKind != FileType::TBD_V3)
Name = Name.drop_front();
- File->addSymbol(SymbolKind::ObjectiveCClass, Name, Targets,
+ File->addSymbol(EncodeKind::ObjectiveCClass, Name, Targets,
SymbolFlags::Undefined | Flags);
}
for (auto &Symbol : Section.ClassEHs)
- File->addSymbol(SymbolKind::ObjectiveCClassEHType, Symbol, Targets,
+ Fil...
[truncated]
|
cyndyishida
added a commit
to cyndyishida/llvm-project
that referenced
this pull request
Jan 30, 2024
A distinction that doesn't _usually_ matter is that the MachO::SymbolKind is really a mapping of entries in TBD files not symbols. To better understand this, rename the enum so it represents an encoding mapped to TBDs as opposed to symbols alone. For example, it can be a bit confusing that "GlobalSymbol" is a enum value when all of those values can represent a GlobalSymbol.
cyndyishida
added a commit
to apple/llvm-project
that referenced
this pull request
Jan 31, 2024
A distinction that doesn't _usually_ matter is that the MachO::SymbolKind is really a mapping of entries in TBD files not symbols. To better understand this, rename the enum so it represents an encoding mapped to TBDs as opposed to symbols alone. For example, it can be a bit confusing that "GlobalSymbol" is a enum value when all of those values can represent a GlobalSymbol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A distinction that doesn't usually matter is that the MachO::SymbolKind is really a mapping of entries in TBD files not symbols. To better understand this, rename the enum so it represents an encoding mapped to TBDs as opposed to symbols alone.
For example, it can be a bit confusing that "GlobalSymbol" is a enum value when all of those values can represent a GlobalSymbol.