[bazel] Allow configuring to exclude the native target … #79776
Conversation
…f compilation targets This is useful for creating a compiler that strictly cross compiles A new attribute "include_native_target" is added to the llvm_configure starlark function, to allow configuring this. This attribute defaults to True to match the existing implementation, so that those that do not need this functionality, do not need to change anything and it will continue to work as expected
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write If you have received no comments on your PR for a week, you can request a review If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
If the native target is not included, don't define the corresponding LLVM_NATIVE_* defines
| @@ -96,15 +82,7 @@ builtin_thread_pointer = select({ | |||
| }) | |||
|
|
|||
| # TODO: We should split out host vs. target here. | |||
There was a problem hiding this comment.
Note that I believe that this TODO can be removed, because this CL should fix it
I left it in just in case it was also referring to something else here
… from the set of compilation targets
This is useful for creating a compiler that strictly cross compiles
The set of allowed targets is checked for the current native target, and if found, the
LLVM_NATIVE_*macros are defined to the correct value. Otherwise they are not definedThis is needed to prevent linker errors due to the LLVM initialize functions (eg:
llvm::InitializeNativeTarget()) that attempt to call the functions if these macros are defined