Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workflows] Fix argument passing in abi-dump jobs (#79658) #79836

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

tstellar
Copy link
Collaborator

This was broken by 859e6aa, which added quotes around the EXTRA_ARGS variable.

@llvmbot
Copy link
Collaborator

llvmbot commented Jan 29, 2024

@llvm/pr-subscribers-github-workflow

Author: Tom Stellard (tstellar)

Changes

This was broken by 859e6aa, which added quotes around the EXTRA_ARGS variable.


Full diff: https://github.com/llvm/llvm-project/pull/79836.diff

1 Files Affected:

  • (modified) .github/workflows/llvm-tests.yml (+2-2)
diff --git a/.github/workflows/llvm-tests.yml b/.github/workflows/llvm-tests.yml
index cc9855ce182b2b8..8a53abee376716f 100644
--- a/.github/workflows/llvm-tests.yml
+++ b/.github/workflows/llvm-tests.yml
@@ -143,7 +143,7 @@ jobs:
           else
             touch llvm.symbols
           fi
-          abi-dumper "$EXTRA_ARGS" -lver ${{ matrix.ref }} -skip-cxx -public-headers ./install/include/${{ needs.abi-dump-setup.outputs.ABI_HEADERS }} -o ${{ matrix.ref }}.abi ./install/lib/libLLVM.so
+          abi-dumper $EXTRA_ARGS -lver ${{ matrix.ref }} -skip-cxx -public-headers ./install/include/${{ needs.abi-dump-setup.outputs.ABI_HEADERS }} -o ${{ matrix.ref }}.abi ./install/lib/libLLVM.so
           # Remove symbol versioning from dumps, so we can compare across major versions.
           sed -i 's/LLVM_${{ matrix.llvm_version_major }}/LLVM_NOVERSION/' ${{ matrix.ref }}.abi
       - name: Upload ABI file
@@ -193,7 +193,7 @@ jobs:
           # FIXME: Reading of gzip'd abi files on the GitHub runners stop
           # working some time in March of 2021, likely due to a change in the
           # runner's environment.
-          abi-compliance-checker "$EXTRA_ARGS" -l libLLVM.so -old build-baseline/*.abi -new build-latest/*.abi || test "${{ needs.abi-dump-setup.outputs.ABI_HEADERS }}" = "llvm-c"
+          abi-compliance-checker $EXTRA_ARGS -l libLLVM.so -old build-baseline/*.abi -new build-latest/*.abi || test "${{ needs.abi-dump-setup.outputs.ABI_HEADERS }}" = "llvm-c"
       - name: Upload ABI Comparison
         if: always()
         uses: actions/upload-artifact@v3

This was broken by 859e6aa, which added
quotes around the EXTRA_ARGS variable.
@tstellar tstellar merged commit b79e6a3 into llvm:release/18.x Jan 29, 2024
12 checks passed
tstellar added a commit to tstellar/llvm-project that referenced this pull request Feb 14, 2024
…79836)

This was broken by 859e6aa, which added
quotes around the EXTRA_ARGS variable.
tstellar added a commit to tstellar/llvm-project that referenced this pull request Feb 14, 2024
…79836)

This was broken by 859e6aa, which added
quotes around the EXTRA_ARGS variable.
tstellar added a commit to tstellar/llvm-project that referenced this pull request Feb 14, 2024
…79836)

This was broken by 859e6aa, which added
quotes around the EXTRA_ARGS variable.
tstellar added a commit to tstellar/llvm-project that referenced this pull request Feb 14, 2024
…79836)

This was broken by 859e6aa, which added
quotes around the EXTRA_ARGS variable.
@pointhex pointhex mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants