Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SelectOpt] Print instruction instead of pointer #80125

Conversation

wangpc-pp
Copy link
Contributor

No description provided.

Created using spr 1.3.4
Copy link
Collaborator

@davemgreen davemgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

Created using spr 1.3.4
wangpc-pp added a commit that referenced this pull request Feb 1, 2024
@wangpc-pp
Copy link
Contributor Author

Committed as 995d21b.
Somehow spr failed with error so I have to land it manually:

  #️⃣   Pull Request #80125                                                                                                                                                                                                         
  🛫  Getting started...                                                                                                                                                                                                          
  🛑  GitHub: Validation Failed                                                                                                                                                                                                   
      Documentation URL: https://docs.github.com/rest/pulls/pulls#update-a-pull-request                                                                                                                                           
      Errors:                                                                                                                                                                                                                     
      - {"code":"invalid","field":"base","message":"Proposed base branch 'refs/heads/main' is invalid","resource":"PullRequest"} 

@wangpc-pp wangpc-pp closed this Feb 1, 2024
@wangpc-pp wangpc-pp deleted the users/wangpc-pp/spr/selectopt-print-instruction-instead-of-pointer branch February 1, 2024 05:15
carlosgalvezp pushed a commit to carlosgalvezp/llvm-project that referenced this pull request Feb 1, 2024
agozillon pushed a commit to agozillon/llvm-project that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants