Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OpenMP] Fix build breakage (NFC) #80313

Merged
merged 2 commits into from
Feb 1, 2024
Merged

[OpenMP] Fix build breakage (NFC) #80313

merged 2 commits into from
Feb 1, 2024

Conversation

kkwli
Copy link
Collaborator

@kkwli kkwli commented Feb 1, 2024

Assign nullptr to the pointer instead.

@kkwli kkwli requested a review from jhuber6 February 1, 2024 17:47
@llvmbot llvmbot added the openmp:libomptarget OpenMP offload runtime label Feb 1, 2024
@kkwli kkwli self-assigned this Feb 1, 2024
jhuber6
jhuber6 reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@jhuber6 jhuber6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that, I forgot that CUdeviceptr is a uintptr_t instead of a void * in CUDA's headers. The input *ptr is intended to be an output variable, so we should set it to zero instead of nullptr.

@kkwli
Copy link
Collaborator Author

kkwli commented Feb 1, 2024

Sorry about that, I forgot that CUdeviceptr is a uintptr_t instead of a void * in CUDA's headers. The input *ptr is intended to be an output variable, so we should set it to zero instead of nullptr.

I see. I will set it to zero here. Thanks.

@jhuber6 jhuber6 merged commit cc0c8e5 into llvm:main Feb 1, 2024
3 of 4 checks passed
@kkwli kkwli deleted the build-breakage branch February 1, 2024 18:35
carlosgalvezp pushed a commit to carlosgalvezp/llvm-project that referenced this pull request Feb 1, 2024
@kkwli
[OpenMP] Fix build breakage (NFC) (llvm#80313)
22493b1 
Assign `nullptr` to the pointer instead.
agozillon pushed a commit to agozillon/llvm-project that referenced this pull request Feb 5, 2024
@kkwli @agozillon
[OpenMP] Fix build breakage (NFC) (llvm#80313)
858982e 
Assign `nullptr` to the pointer instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhuber6 jhuber6 jhuber6 approved these changes

Assignees

@kkwli kkwli

Labels
openmp:libomptarget OpenMP offload runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kkwli @jhuber6 @llvmbot