Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MachinePipeliner] Fix missing requirements for tests #80386

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

ytmukai
Copy link
Contributor

@ytmukai ytmukai commented Feb 2, 2024

Add asserts requirements for tests that verify debug output.

Add asserts requirements for tests that verify debug output.
@llvmbot
Copy link
Collaborator

llvmbot commented Feb 2, 2024

@llvm/pr-subscribers-backend-aarch64

Author: Yuta Mukai (ytmukai)

Changes

Add asserts requirements for tests that verify debug output.


Full diff: https://github.com/llvm/llvm-project/pull/80386.diff

8 Files Affected:

  • (modified) llvm/test/CodeGen/AArch64/sms-acceptable-loop1.mir (+1)
  • (modified) llvm/test/CodeGen/AArch64/sms-acceptable-loop2.mir (+1)
  • (modified) llvm/test/CodeGen/AArch64/sms-acceptable-loop3.mir (+1)
  • (modified) llvm/test/CodeGen/AArch64/sms-acceptable-loop4.mir (+1)
  • (modified) llvm/test/CodeGen/AArch64/sms-unacceptable-loop1.mir (+1)
  • (modified) llvm/test/CodeGen/AArch64/sms-unacceptable-loop2.mir (+1)
  • (modified) llvm/test/CodeGen/AArch64/sms-unpipeline-insts1.mir (+1)
  • (modified) llvm/test/CodeGen/AArch64/sms-unpipeline-insts2.mir (+1)
diff --git a/llvm/test/CodeGen/AArch64/sms-acceptable-loop1.mir b/llvm/test/CodeGen/AArch64/sms-acceptable-loop1.mir
index ed2bd73a7861a..c552da3eca0c8 100644
--- a/llvm/test/CodeGen/AArch64/sms-acceptable-loop1.mir
+++ b/llvm/test/CodeGen/AArch64/sms-acceptable-loop1.mir
@@ -1,4 +1,5 @@
 # RUN: llc --verify-machineinstrs -mtriple=aarch64 -o - %s -run-pass pipeliner -aarch64-enable-pipeliner -debug-only=pipeliner 2>&1 | FileCheck %s
+# REQUIRES: asserts
 
 # An acceptable loop by pipeliner: TBB == ExitBB, FBB == LoopBB, Branch with NZCV flags
 # CHECK: Schedule Found? 1
diff --git a/llvm/test/CodeGen/AArch64/sms-acceptable-loop2.mir b/llvm/test/CodeGen/AArch64/sms-acceptable-loop2.mir
index 5cf6367354ecc..6171abc52bb93 100644
--- a/llvm/test/CodeGen/AArch64/sms-acceptable-loop2.mir
+++ b/llvm/test/CodeGen/AArch64/sms-acceptable-loop2.mir
@@ -1,4 +1,5 @@
 # RUN: llc --verify-machineinstrs -mtriple=aarch64 -o - %s -run-pass pipeliner -aarch64-enable-pipeliner -debug-only=pipeliner 2>&1 | FileCheck %s
+# REQUIRES: asserts
 
 # An acceptable loop by pipeliner: TBB == LoopBB, FBB == ExitBB, Branch with NZCV flags
 # CHECK: Schedule Found? 1
diff --git a/llvm/test/CodeGen/AArch64/sms-acceptable-loop3.mir b/llvm/test/CodeGen/AArch64/sms-acceptable-loop3.mir
index 652770e3fcfa8..94dd299d1caa7 100644
--- a/llvm/test/CodeGen/AArch64/sms-acceptable-loop3.mir
+++ b/llvm/test/CodeGen/AArch64/sms-acceptable-loop3.mir
@@ -1,4 +1,5 @@
 # RUN: llc --verify-machineinstrs -mtriple=aarch64 -o - %s -run-pass pipeliner -aarch64-enable-pipeliner -pipeliner-enable-copytophi=0 -debug-only=pipeliner 2>&1 | FileCheck %s
+# REQUIRES: asserts
 
 # An acceptable loop by pipeliner: TBB == ExitBB, FBB == LoopBB, Compare and branch
 # CHECK: Schedule Found? 1
diff --git a/llvm/test/CodeGen/AArch64/sms-acceptable-loop4.mir b/llvm/test/CodeGen/AArch64/sms-acceptable-loop4.mir
index 95d64cae5b780..fbd74a777aa1e 100644
--- a/llvm/test/CodeGen/AArch64/sms-acceptable-loop4.mir
+++ b/llvm/test/CodeGen/AArch64/sms-acceptable-loop4.mir
@@ -1,4 +1,5 @@
 # RUN: llc --verify-machineinstrs -mtriple=aarch64 -o - %s -run-pass pipeliner -aarch64-enable-pipeliner -pipeliner-enable-copytophi=0 -debug-only=pipeliner 2>&1 | FileCheck %s
+# REQUIRES: asserts
 
 # An acceptable loop by pipeliner TBB == LoopBB, FBB == ExitBB, Compare and branch
 # CHECK: Schedule Found? 1
diff --git a/llvm/test/CodeGen/AArch64/sms-unacceptable-loop1.mir b/llvm/test/CodeGen/AArch64/sms-unacceptable-loop1.mir
index 79dc1482c748f..42774732ecbad 100644
--- a/llvm/test/CodeGen/AArch64/sms-unacceptable-loop1.mir
+++ b/llvm/test/CodeGen/AArch64/sms-unacceptable-loop1.mir
@@ -1,4 +1,5 @@
 # RUN: llc --verify-machineinstrs -mtriple=aarch64 -o - %s -run-pass pipeliner -aarch64-enable-pipeliner -debug-only=pipeliner 2>&1 | FileCheck %s
+# REQUIRES: asserts
 
 # An unacceptable loop by pipeliner: No exits
 # CHECK: Unable to analyzeLoop, can NOT pipeline Loop
diff --git a/llvm/test/CodeGen/AArch64/sms-unacceptable-loop2.mir b/llvm/test/CodeGen/AArch64/sms-unacceptable-loop2.mir
index c3807ae272c6c..4f5b85f05e1c2 100644
--- a/llvm/test/CodeGen/AArch64/sms-unacceptable-loop2.mir
+++ b/llvm/test/CodeGen/AArch64/sms-unacceptable-loop2.mir
@@ -1,4 +1,5 @@
 # RUN: llc --verify-machineinstrs -mtriple=aarch64 -o - %s -run-pass pipeliner -aarch64-enable-pipeliner -pipeliner-enable-copytophi=0 -debug-only=pipeliner 2>&1 | FileCheck %s
+# REQUIRES: asserts
 
 # An unacceptable loop by pipeliner: The operand of the compare and branch is not defined in the loop
 # CHECK: Unable to analyzeLoop, can NOT pipeline Loop
diff --git a/llvm/test/CodeGen/AArch64/sms-unpipeline-insts1.mir b/llvm/test/CodeGen/AArch64/sms-unpipeline-insts1.mir
index 5973a44308253..fb28174a79a4a 100644
--- a/llvm/test/CodeGen/AArch64/sms-unpipeline-insts1.mir
+++ b/llvm/test/CodeGen/AArch64/sms-unpipeline-insts1.mir
@@ -1,4 +1,5 @@
 # RUN: llc --verify-machineinstrs -mtriple=aarch64 -mcpu=neoverse-n1 -o - %s -run-pass pipeliner -aarch64-enable-pipeliner -debug-only=pipeliner 2>&1 | FileCheck %s
+# REQUIRES: asserts
 
 # Check that instructions referencing NZCV are not pipelined
 
diff --git a/llvm/test/CodeGen/AArch64/sms-unpipeline-insts2.mir b/llvm/test/CodeGen/AArch64/sms-unpipeline-insts2.mir
index fdecbffdd4490..c5b76d88ff00d 100644
--- a/llvm/test/CodeGen/AArch64/sms-unpipeline-insts2.mir
+++ b/llvm/test/CodeGen/AArch64/sms-unpipeline-insts2.mir
@@ -1,4 +1,5 @@
 # RUN: llc --verify-machineinstrs -mtriple=aarch64 -o - %s -run-pass pipeliner -aarch64-enable-pipeliner -pipeliner-enable-copytophi=0 -debug-only=pipeliner 2>&1 | FileCheck %s
+# REQUIRES: asserts
 
 # An acceptable loop by pipeliner TBB == LoopBB, FBB == ExitBB, Compare and branch
 # CHECK: SU([[SU0:[0-9]+]]):   [[V0:%[0-9]+]]:gpr64common = SUBXri [[V1:%[0-9]+]]:gpr64common, 1, 0

@ytmukai ytmukai merged commit 374a600 into llvm:main Feb 2, 2024
5 checks passed
@ytmukai ytmukai deleted the fix-missing-requirements branch February 2, 2024 06:04
agozillon pushed a commit to agozillon/llvm-project that referenced this pull request Feb 5, 2024
Add asserts requirements for tests that verify debug output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants