Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coverage][docs] for the main region array there shoudn't be a numRegionArrays : LEB128 field #80531

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

whentojump
Copy link
Member

The docs in question are here: https://llvm.org/docs/CoverageMappingFormat.html#mapping-regions

Even in the initial commit this numRegionArrays : LEB128 field was not there

  • In reader
    • The quoted starting line corresponds to expr1RHS : LEB128 earlier in docs
    • The quoted ending line corresponds to regionsForFile0 later in docs
  • In writer
    • The quoted starting line corresponds to expr1RHS : LEB128 earlier in docs
    • The quoted ending line corresponds to numRegions : LEB128 later in docs
      • Note this variable is for the sub-array, not the main array
      • The first such variable is written before the loop. If there're more than one sub-arrays, later ones are written within the loop at this line

More recent code has refactored a bit (mostly in the writer) but the covmap format around this place stays the same: without this numRegionArrays : LEB128 field

Copy link

github-actions bot commented Feb 3, 2024

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@whentojump
Copy link
Member Author

whentojump commented Feb 3, 2024

@ornata @MaskRay @jroelofs please take a look. Thanks!

@whentojump
Copy link
Member Author

Ping

Cc @minglotus-6: Can you please confirm this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant