Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeGen] Resolve FIXME: Try SCEV getRange #80623

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AtariDreams
Copy link
Contributor

@AtariDreams AtariDreams commented Feb 5, 2024

Using the range to see if an expression is guaranteed to be a safe entry rather than only accepting a constant value allows us to examine more expressions.

Copy link

github-actions bot commented Feb 5, 2024

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo.
Please turn off Keep my email addresses private setting in your account.

@dtcxzyw
Copy link
Member

dtcxzyw commented Feb 5, 2024

Tests?

@dtcxzyw dtcxzyw requested a review from nikic February 5, 2024 08:54
@AtariDreams AtariDreams changed the title Resolve FIXME: Try SCEV getRange. [CodeGen] Resolve FIXME: Try SCEV getRange Feb 7, 2024
llvm/lib/CodeGen/SafeStack.cpp Outdated Show resolved Hide resolved
@AtariDreams AtariDreams requested a review from nikic April 2, 2024 18:12
Using the range to see if an expression is guaranteed to be a safe entry rather than only accepting a constant value allows us to examine more expressions.
Copy link
Contributor

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants