[SystemZ] Implement A, O and R inline assembly format flags #80685
+36
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iii-i
force-pushed
the
systemz-inlineasm-ars
branch
from
49d21f7
to
7744e2b
Compare
uweigand
approved these changes
Feb 7, 2024
| case 'A': | ||
| // Unlike EmitMachineNode(), EmitSpecialNode(INLINEASM) does not call | ||
| // setMemRefs(), so MI->memoperands() is empty and the alignment | ||
| // information is not available. |
There was a problem hiding this comment.
Hmm. This is unfortunate, as it will lead to less efficient code being emitted without any indication to the user ...
I guess this is OK for now (probably still better than an error) - but can we look into actually fixing the underlying problem as well?
There was a problem hiding this comment.
Ok, I'll look into this. Ideally this will be as simple as adding an extra call, but, of course, there may be some fallout that will have to be investigated.
Implement the following assembly format flags, which are already
supported by GCC:
'A': On z14 or higher: If operand is a mem print the alignment
hint usable with vl/vst prefixed by a comma.
'O': print only the displacement of a memory reference or address.
'R': print only the base register of a memory reference or address.
Implement 'A' conservatively, since the memory operand alignment
information is not available for INLINEASM at the moment.
iii-i
force-pushed
the
systemz-inlineasm-ars
branch
from
7744e2b
to
e22c854
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the following assembly format flags, which are already
supported by GCC:
Implement 'A' conservatively, since the memory operand alignment
information is not available for INLINEASM at the moment.