Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark llvm/test/CodeGen/WebAssembly/immediates.ll as passing on MIPS #80771

Merged

Conversation

dschuff
Copy link
Member

@dschuff dschuff commented Feb 6, 2024

Fixes #80533

@llvmbot
Copy link
Collaborator

llvmbot commented Feb 6, 2024

@llvm/pr-subscribers-backend-webassembly

Author: Derek Schuff (dschuff)

Changes

Fixes #80533


Full diff: https://github.com/llvm/llvm-project/pull/80771.diff

1 Files Affected:

  • (modified) llvm/test/CodeGen/WebAssembly/immediates.ll (-6)
diff --git a/llvm/test/CodeGen/WebAssembly/immediates.ll b/llvm/test/CodeGen/WebAssembly/immediates.ll
index e2342f391b13c..9de5aa7402493 100644
--- a/llvm/test/CodeGen/WebAssembly/immediates.ll
+++ b/llvm/test/CodeGen/WebAssembly/immediates.ll
@@ -1,11 +1,5 @@
 ; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt -wasm-keep-registers | FileCheck %s
 
-; Usually MIPS hosts uses a legacy (non IEEE 754-2008) encoding for NaNs.
-; Tests like `nan_f32` failed in attempt to compare hard-coded IEEE 754-2008
-; NaN value and a legacy NaN value provided by a system.
-; FIXME: This should be based on host not target, but there's no "system-mips" feature.
-; XFAIL: target={{(mips|mipsel|mips64|mips64el)-.*}}
-
 ; Test that basic immediates assemble as expected.
 
 target triple = "wasm32-unknown-unknown"

@dschuff
Copy link
Member Author

dschuff commented Feb 6, 2024

@wzssyqa does this work for you?

@wzssyqa
Copy link
Contributor

wzssyqa commented Feb 6, 2024

Yes. It is good for me.

@dschuff dschuff merged commit c0cb0be into llvm:main Feb 6, 2024
6 of 7 checks passed
@dschuff dschuff deleted the llvm/test/CodeGen/WebAssembly/immediates.ll branch February 6, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

llvm/test/CodeGen/WebAssembly/immediates.ll: passes for mips now
3 participants